From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934552AbcA1Oqz (ORCPT ); Thu, 28 Jan 2016 09:46:55 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:35138 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932685AbcA1Oqw (ORCPT ); Thu, 28 Jan 2016 09:46:52 -0500 Message-ID: <1453992410.7627.39.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH net 0/4] net: add rx_unhandled stat counter From: Eric Dumazet To: Jarod Wilson Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jiri Pirko , Daniel Borkmann , Tom Herbert , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , netdev@vger.kernel.org Date: Thu, 28 Jan 2016 06:46:50 -0800 In-Reply-To: <1453992265.7627.37.camel@edumazet-glaptop2.roam.corp.google.com> References: <1453489882-57948-1-git-send-email-jarod@redhat.com> <1453926098-40181-1-git-send-email-jarod@redhat.com> <1453928987.20722.29.camel@edumazet-glaptop2.roam.corp.google.com> <20160128060215.GB59058@redhat.com> <20160128061808.GD59058@redhat.com> <1453986002.7627.20.camel@edumazet-glaptop2.roam.corp.google.com> <20160128143806.GE59058@redhat.com> <1453992162.7627.35.camel@edumazet-glaptop2.roam.corp.google.com> <1453992265.7627.37.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-01-28 at 06:44 -0800, Eric Dumazet wrote: > On Thu, 2016-01-28 at 06:42 -0800, Eric Dumazet wrote: > > > > > Sure, you also can set stats64->rx_unhandled to 0 here, just to be 100% > > safe. > > And not add the memset(stats64, 0, sizeof(*stats64)), since we have the > guarantee to properly init whole stats64 structure. Or a more tricky memset((char *)stats64 + sizeof(struct net_device_stats), 0, sizeof(*stats64) - sizeof(struct net_device_stats));