From: Jaehoon Chung <jh80.chung@samsung.com>
To: linux-mmc@vger.kernel.org
Cc: ulf.hansson@linaro.org, sonic.zhang@analog.com,
robert.jarzmik@free.fr, Jaehoon Chung <jh80.chung@samsung.com>
Subject: [PATCH 12/12] mmc: block: don't use the OR operation for flag of data
Date: Fri, 29 Jan 2016 13:06:11 +0900 [thread overview]
Message-ID: <1454040371-31625-13-git-send-email-jh80.chung@samsung.com> (raw)
In-Reply-To: <1454040371-31625-1-git-send-email-jh80.chung@samsung.com>
After removed the MMC_DATA_STREAM, only two flags are remained.
(MMC_DATA_READ and MMC_DATA_WRITE)
The flags of READ and WRITE can't be used together.
That's why it doesn't need to use "OR' operation.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/mmc/card/block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 5914263..e7449cb 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -1525,13 +1525,13 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
}
if (rq_data_dir(req) == READ) {
brq->cmd.opcode = readcmd;
- brq->data.flags |= MMC_DATA_READ;
+ brq->data.flags = MMC_DATA_READ;
if (brq->mrq.stop)
brq->stop.flags = MMC_RSP_SPI_R1 | MMC_RSP_R1 |
MMC_CMD_AC;
} else {
brq->cmd.opcode = writecmd;
- brq->data.flags |= MMC_DATA_WRITE;
+ brq->data.flags = MMC_DATA_WRITE;
if (brq->mrq.stop)
brq->stop.flags = MMC_RSP_SPI_R1B | MMC_RSP_R1B |
MMC_CMD_AC;
@@ -1800,7 +1800,7 @@ static void mmc_blk_packed_hdr_wrq_prep(struct mmc_queue_req *mqrq,
brq->data.blksz = 512;
brq->data.blocks = packed->blocks + hdr_blocks;
- brq->data.flags |= MMC_DATA_WRITE;
+ brq->data.flags = MMC_DATA_WRITE;
brq->stop.opcode = MMC_STOP_TRANSMISSION;
brq->stop.arg = 0;
--
1.9.1
next prev parent reply other threads:[~2016-01-29 4:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 4:05 [PATCH 00/12] mmc: remove the MMC_DATA_STREAM flag Jaehoon Chung
2016-01-29 4:06 ` [PATCH 01/12] mmc: core: use the defined function to check whether card is removable Jaehoon Chung
2016-01-29 4:06 ` [PATCH 02/12] mmc: atmel-mci: remove the MMC_DATA_STREAM flag Jaehoon Chung
2016-01-29 4:06 ` [PATCH 03/12] mmc: bfin_sdh: " Jaehoon Chung
2016-01-29 4:06 ` [PATCH 04/12] mmc: davinci_mmc: " Jaehoon Chung
2016-01-29 4:06 ` [PATCH 05/12] mmc: dw_mmc: " Jaehoon Chung
2016-01-29 4:06 ` [PATCH 06/12] mmc: jz4740_mmc: " Jaehoon Chung
2016-01-29 4:06 ` [PATCH 07/12] mmc: mxcmmc: " Jaehoon Chung
2016-01-29 4:06 ` [PATCH 08/12] mmc: pxamci: " Jaehoon Chung
2016-01-29 9:25 ` Robert Jarzmik
2016-01-29 4:06 ` [PATCH 09/12] mmc: s3cmci: " Jaehoon Chung
2016-01-29 4:06 ` [PATCH 10/12] mmc: sunxi-mmc: " Jaehoon Chung
2016-01-29 4:06 ` [PATCH 11/12] mmc: core: " Jaehoon Chung
2016-01-29 4:06 ` Jaehoon Chung [this message]
2016-01-29 4:28 ` [PATCH 00/12] mmc: " Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454040371-31625-13-git-send-email-jh80.chung@samsung.com \
--to=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=sonic.zhang@analog.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.