From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse Date: Fri, 29 Jan 2016 14:03:09 +0200 Message-ID: <1454068989.3454.25.camel@gmail.com> References: <1453199833-10401-1-git-send-email-shubhangi.shrivastava@intel.com> <1453199833-10401-2-git-send-email-shubhangi.shrivastava@intel.com> <1453814570.2695.18.camel@gmail.com> <56AB2A7E.6030403@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f66.google.com (mail-pa0-f66.google.com [209.85.220.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id A844D6E97F for ; Fri, 29 Jan 2016 04:03:16 -0800 (PST) Received: by mail-pa0-f66.google.com with SMTP id x8so695580pav.3 for ; Fri, 29 Jan 2016 04:03:16 -0800 (PST) In-Reply-To: <56AB2A7E.6030403@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shubhangi Shrivastava , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE2LTAxLTI5IGF0IDE0OjMxICswNTMwLCBTaHViaGFuZ2kgU2hyaXZhc3RhdmEg d3JvdGU6Cj4gCj4gT24gVHVlc2RheSAyNiBKYW51YXJ5IDIwMTYgMDY6NTIgUE0sIEFuZGVyIENv bnNlbHZhbiBEZSBPbGl2ZWlyYSB3cm90ZToKPiA+IE9uIFR1ZSwgMjAxNi0wMS0xOSBhdCAxNjow NyArMDUzMCwgU2h1YmhhbmdpIFNocml2YXN0YXZhIHdyb3RlOgo+ID4gPiBDdXJyZW50IERQIGRl dGVjdGlvbiBoYXMgRFBDRCBvcGVyYXRpb25zIHNwbGl0IGFjcm9zcwo+ID4gPiBpbnRlbF9kcF9o cGRfcHVsc2UgYW5kIGludGVsX2RwX2RldGVjdCB3aGljaCBjb250YWlucwo+ID4gPiBkdXBsaWNh dGVzIGFzIHdlbGwuIEFsc28gaW50ZWxfZHBfZGV0ZWN0IGlzIGNhbGxlZAo+ID4gPiBkdXJpbmcg bW9kZXMgZW51bWVyYXRpb24gYXMgd2VsbCB3aGljaCB3aWxsIHJlc3VsdAo+ID4gPiBpbiBtdWx0 aXBsZSBkcGNkIG9wZXJhdGlvbnMuIFNvIHRoaXMgcGF0Y2ggdHJpZXMKPiA+ID4gdG8gc29sdmUg Ym90aCB0aGVzZSBieSBicmluZ2luZyBhbGwgRFBDRCBvcGVyYXRpb25zCj4gPiA+IGluIG9uZSBz aW5nbGUgZnVuY3Rpb24gYW5kIG1ha2UgaW50ZWxfZHBfZGV0ZWN0Cj4gPiA+IHVzZSBleGlzdGlu ZyB2YWx1ZXMgaW5zdGVhZCBvZiByZXBlYXRpbmcgc2FtZSBzdGVwcy4KPiA+ID4gCj4gPiA+IHYy OiBQdWxsZWQgaW4gYSBodW5rIGZyb20gbGFzdCBwYXRjaCBvZiB0aGUgc2VyaWVzIHRvCj4gPiA+ ICAgICAgdGhpcyBwYXRjaC4gKEFuZGVyKQo+ID4gPiB2MzogQWRkZWQgTVNUIGhvdHBsdWcgaGFu ZGxpbmcuIChBbmRlcikKPiA+ID4gCj4gPiA+IFRlc3RlZC1ieTogTmF0aGFuIEQgQ2lvYmFudSA8 bmF0aGFuLmQuY2lvYmFudUBpbnRlbC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFNpdmFrdW1h ciBUaHVsYXNpbWFuaSA8c2l2YWt1bWFyLnRodWxhc2ltYW5pQGludGVsLmNvbT4KPiA+ID4gU2ln bmVkLW9mZi1ieTogU2h1YmhhbmdpIFNocml2YXN0YXZhIDxzaHViaGFuZ2kuc2hyaXZhc3RhdmFA aW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jIHwgNzEgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiA+ID4gLS0tLS0K PiA+ID4gLQo+ID4gPiAgIDEgZmlsZSBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCAyNyBkZWxl dGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcC5jCj4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBp bmRleCA4OTY5ZmY5Li44MmVlMThkIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcC5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMKPiA+IFsuLi5dCj4gPiAKPiA+ID4gQEAgLTQ2OTMsNyArNDcxNyw4IEBAIGludGVsX2RwX2Rl dGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gPiBib29sCj4gPiA+IGZv cmNlKQo+ID4gPiAgIAkJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNfZGlzY29ubmVjdGVkOwo+ID4g PiAgIAl9Cj4gPiA+ICAgCj4gPiA+IC0JaW50ZWxfZHBfbG9uZ19wdWxzZShpbnRlbF9kcC0+YXR0 YWNoZWRfY29ubmVjdG9yKTsKPiA+ID4gKwlpZiAoZm9yY2UpCj4gPiA+ICsJCWludGVsX2RwX2xv bmdfcHVsc2UoaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3Rvcik7Cj4gPiBJIGRpZG4ndCBub3Rp Y2UgdGhpcyBhdCBmaXJzdCwgYnV0IGZvcmNlIGlzIG5vdCB0aGUgcmlnaHQgdGhpbmcgdG8gY2hl Y2sgZm9yCj4gPiBoZXJlLiBJdCBpcyBiYXNpY2FsbHkgaW50ZW5kZWQgdG8gYXZvaWQgZG9pbmcg bG9hZCBkZXRlY3Rpb24gKHNlZQo+ID4gaW50ZWxfZ2V0X2xvYWRfZGV0ZWN0X3BpcGUoKSkgb24g YXV0b21hdGVkIHBvbGxpbmcuIEJ1dCB3ZSBzdGlsbCBoYXZlIHRvIHRyeQo+ID4gZGV0ZWN0aW9u IGhlcmUgd2hlbiBmb3JjZSA9IGZhbHNlLCBvdGhlcndpc2UgdGhpcyB3aWxsIGNhdXNlIGEgcmVn cmVzc2lvbi4KPiA+IAo+ID4gSWYgeW91IHBsdWcgaW4gYSBEUCBkZXZpY2Ugd2hpbGUgc3VzcGVu ZGVkLCB0aGF0IGRldmljZSB3b24ndCBnZXQgZGV0ZWN0ZWQsCj4gPiBzaW5jZSB3ZSBkb24ndCBn ZXQgYW4gSFBEIGZvciBpdC4gUHJldmlvdXNseSwgdGhlIGNhbGwgZG8gaW50ZWxfZHBfZGV0ZWN0 KCkKPiA+IHdpdGgKPiA+IGZvcmNlID0gZmFsc2UgZnJvbSBpbnRlbF9kcm1fcmVzdW1lKCkgKHZp YSBkcm1faGVscGVyX2hwZF9pcnFfZXZlbnQoKSkgd291bGQKPiA+IGNhdXNlIGEgZnVsbCBkZXRl Y3Rpb24uCj4gPiAKPiA+IFRvIGF2b2lkIHRoZSByZXBlYXRlZCBEUENEIG9wZXJhdGlvbnMsIEkg dGhpbmsgd2UgbmVlZCBhIG1vcmUgZXhwbGljaXQKPiA+IG1lY2hhbmlzbQo+ID4gdG8gc2lnbmFs IHRoYXQgd2UgYWxyZWFkeSBoYW5kbGVkIHRoZSBsb25nIHB1bHNlIHZpYSB0aGUgSFBEIGhhbmRs ZXIuIEluCj4gPiBpbnRlbF9kcF9ocGRfcHVsc2UoKSB3ZSBjb3VsZCBzZXQgYSBmbGFnIHRoYXQg dGVsbHMgd2UganVzdCBoYW5kbGVkIGEgbG9uZwo+ID4gcHVsc2UKPiA+IGZvciB0aGUgZ2l2ZW4g cG9ydC4gVGhlIGNhbGwgdG8gaW50ZWxfZHBfbG9uZ19wdWxzZSgpIGluIGludGVsX2RwX2RldGVj dCgpCj4gPiB3b3VsZAo+ID4gdGhlbiBiZSBkZXBlbmRlbnQgb24gdGhhdCBmbGFnLgo+ID4gCj4g PiBGb3IgdGhhdCByZWFzb24gSSBoYXZlIHRvIHJldHJhY3QgbXkgUi1iIGZyb20gdGhpcyBwYXRj aC4KPiA+IAo+ID4gQW5kZXIKPiAKPiBDYWxsIHRvIGludGVsX2RwX2RldGVjdCgpIGZyb20gZ2V0 X21vZGVzIGlzIHdpdGggZm9yY2Ugc2V0IHRvIHRydWUgd2hpbGUgCj4gZnJvbSByZXN1bWUgdGhl IGNhbGwgaXMgd2l0aCBmb3JjZSBzZXQgdG8gZmFsc2UuLiBJdCBzaG91bGQgYmUgaW4gdGhlIAo+ IG9wcG9zaXRlIG1hbm5lciBhcyBnZXRfbW9kZXMgc2hvdWxkIG5vdCByZXF1aXJlIGZ1bGwgZGV0 ZWN0aW9uIHdoZXJlYXMgCj4gcmVzdW1lIHNob3VsZC4gU28sIHRoaXMgbmVlZHMgdG8gYmUgY2xl YW5lZCB1cCB0aGVyZS4gQWZ0ZXIgbWVyZ2Ugb2YgCj4gdGhlc2UgcGF0Y2hlcywgd2lsbCBsb29r IGludG8gY2xlYW5pbmcgdXAgdGhhdCBwYXJ0IG9mIHRoZSBjb2RlLgoKVGhhdCByZWFsbHkgZGVw ZW5kcyBvbiB3aGF0IHRoZSBmb3JjZSBwYXJhbWV0ZXIgaXMgc3VwcG9zZWQgdG8gbWVhbi4gVGhl CmRvY3VtZW50YXRpb24gc3RhdGVzIHRoYXQgImZvcmNlIGlzIHNldCB0byBmYWxzZSB3aGlsc3Qg cG9sbGluZywgdHJ1ZSB3aGVuCmNoZWNraW5nIHRoZSBjb25uZWN0b3IgZHVlIHRvIGEgdXNlciBy ZXF1ZXN0Ii4gQSBsb29rIHRocm91Z2ggZ2l0IGhpc3Rvcnkgc2hvd3MKdGhlIHBhcmFtZXRlciB3 YXMgYWRkZWQgdG8gcmVkdWNlIHRpbWUgd2FzdGVkIGRvaW5nIGxvYWQgZGV0ZWN0aW9uIChkb2lu ZyBhIG1vZGUKc2V0IGluIG9yZGVyIHRvIGNoZWNrIGlmIHRoZXJlIGlzIGEgZGV2aWNlIGNvbm5l Y3RlZCkgZm9yIGhhcmR3YXJlIHRoYXQgbmVlZHMgaXQKKGNvbW1pdCA3YjMzNGZjYjQ1YjcpLgoK QXMgZmFyIGFzIEkgY2FuIHRlbGwsIGFjcm9zcyBhbGwgdGhlIGRybSBkcml2ZXJzLCB0aGF0IHBh cmFtZXRlciBpcyBvbmx5IHVzZWQgdG8KYXZvaWQgZG9pbmcgbG9hZCBkZXRlY3Rpb24uCgpBbm90 aGVyIHRoaW5nIHRvIGNvbnNpZGVyIGlzIHRoYXQgdGhlIGRyaXZlciBtYXkgc3dpdGNoIHRvIHBv bGxpbmcgaWYgaXQgZGV0ZWN0cwphbiBIUEQgc3Rvcm0uIFdoZW4gdGhlIGRldGVjdCBjYWxscyBj b21lIGZyb20gcG9sbGluZywgdGhlIGNvZGUgaW4gdGhpcyBwYXRjaAp3aWxsIHNpbXBseSBhdm9p ZCBhbnkgZGV0ZWN0aW9uLgoKCj4gTW9yZW92ZXIsIGludGVsX2RwX2RldGVjdCgpIHdpbGwgYmUg Y2FsbGVkIGZyb20gCj4gZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KCkgaW4gcG9sbGluZyBzY2Vu YXJpb3Mgb25seSAod2hlbiAKPiBEUk1fQ09OTkVDVE9SX1BPTExfSFBEIGZsYWcgaXMgc2V0IGlu IGNvbm5lY3Rvci0+cG9sbGVkKS4gU28sIHNlZW1zIGxpa2UgCj4gdGhpcyBjb2RlIGhlcmUsIGRv ZXNuJ3QgcmVhbGx5IGNyZWF0ZSBhIHJlZ3Jlc3Npb24gZm9yIHJlYWx0aW1lIHNjZW5hcmlvcy4K CkkgZG9uJ3Qga25vdyB3aGF0IHlvdSBtZWFuIGJ5IHJlYWx0aW1lIHNjZW5hcmlvcywgYnV0IHRo ZSByZWdyZXNzaW9uIGlzIHZlcnkKcmVhbC4gVXNpbmcgYSBrZXJuZWwgd2l0aCB5b3VyIHBhdGNo ZXMgYXBwbGllZCwgc3VzcGVuZCB3aGlsZSB0aGVyZSBpcyBubyBEUAptb25pdG9yIGF0dGFjaGVk LCBhdHRhY2ggdGhlIG1vbml0b3Igd2hpbGUgc3VzcGVuZGVkIGFuZCB0aGVuIHdha2UgdXAuIE5v dGljZQpob3cgdGhlIGNvbm5lY3RvciBzdGF0ZSBkb2Vzbid0IGNoYW5nZS4gWW91IGNhbiBjaGVj ayB0aGUgaTkxNV9kaXNwbGF5X2luZm8gZmlsZQppbiBkZWJ1Z2ZzLCBmb3IgaW5zdGFuY2UuCgoK QW5kZXIKCj4gPiAgIAo+ID4gPiAgIAlpZiAoaW50ZWxfY29ubmVjdG9yLT5kZXRlY3RfZWRpZCkK PiA+ID4gICAJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZDsKPiA+ID4gQEAgLTUw MjYsMjUgKzUwNTEsMjUgQEAgaW50ZWxfZHBfaHBkX3B1bHNlKHN0cnVjdCBpbnRlbF9kaWdpdGFs X3BvcnQKPiA+ID4gKmludGVsX2RpZ19wb3J0LCBib29sIGxvbmdfaHBkKQo+ID4gPiAgIAkJLyog aW5kaWNhdGUgdGhhdCB3ZSBuZWVkIHRvIHJlc3RhcnQgbGluayB0cmFpbmluZyAqLwo+ID4gPiAg IAkJaW50ZWxfZHAtPnRyYWluX3NldF92YWxpZCA9IGZhbHNlOwo+ID4gPiAgIAo+ID4gPiAtCQlp ZiAoIWludGVsX2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoZGV2X3ByaXYsCj4gPiA+IGludGVsX2Rp Z19wb3J0KSkKPiA+ID4gLQkJCWdvdG8gbXN0X2ZhaWw7Cj4gPiA+IC0KPiA+ID4gLQkJaWYgKCFp bnRlbF9kcF9nZXRfZHBjZChpbnRlbF9kcCkpIHsKPiA+ID4gLQkJCWdvdG8gbXN0X2ZhaWw7Cj4g PiA+IC0JCX0KPiA+ID4gLQo+ID4gPiAtCQlpbnRlbF9kcF9wcm9iZV9vdWkoaW50ZWxfZHApOwo+ ID4gPiArCQlpbnRlbF9kcF9sb25nX3B1bHNlKGludGVsX2RwLT5hdHRhY2hlZF9jb25uZWN0b3Ip Owo+ID4gPiArCQlpZiAoaW50ZWxfZHAtPmlzX21zdCkKPiA+ID4gKwkJCXJldCA9IElSUV9IQU5E TEVEOwo+ID4gPiArCQlnb3RvIHB1dF9wb3dlcjsKPiA+ID4gICAKPiA+ID4gLQkJaWYgKCFpbnRl bF9kcF9wcm9iZV9tc3QoaW50ZWxfZHApKSB7Cj4gPiA+IC0JCQlkcm1fbW9kZXNldF9sb2NrKCZk ZXYKPiA+ID4gLT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4LAo+ID4gPiBOVUxMKTsKPiA+ ID4gLQkJCWludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKGludGVsX2RwKTsKPiA+ID4gLQkJCWRy bV9tb2Rlc2V0X3VubG9jaygmZGV2Cj4gPiA+IC0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRl eCk7Cj4gPiA+IC0JCQlnb3RvIG1zdF9mYWlsOwo+ID4gPiAtCQl9Cj4gPiA+ICAgCX0gZWxzZSB7 Cj4gPiA+ICAgCQlpZiAoaW50ZWxfZHAtPmlzX21zdCkgewo+ID4gPiAtCQkJaWYgKGludGVsX2Rw X2NoZWNrX21zdF9zdGF0dXMoaW50ZWxfZHApID09IAo+ID4gPiAtRUlOVkFMKQo+ID4gPiAtCQkJ CWdvdG8gbXN0X2ZhaWw7Cj4gPiA+ICsJCQlpZiAoaW50ZWxfZHBfY2hlY2tfbXN0X3N0YXR1cyhp bnRlbF9kcCkgPT0gCj4gPiA+IC1FSU5WQUwpIHsKPiA+ID4gKwkJCQkvKgo+ID4gPiArCQkJCSAq IElmIHdlIHdlcmUgaW4gTVNUIG1vZGUsIGFuZCBkZXZpY2UgaXMKPiA+ID4gbm90Cj4gPiA+ICsJ CQkJICogdGhlcmUsIGdldCBvdXQgb2YgTVNUIG1vZGUKPiA+ID4gKwkJCQkgKi8KPiA+ID4gKwkJ CQlEUk1fREVCVUdfS01TKCJNU1QgZGV2aWNlIG1heSBoYXZlCj4gPiA+IGRpc2FwcGVhcmVkICVk IHZzICVkXG4iLAo+ID4gPiArCQkJCQlpbnRlbF9kcC0+aXNfbXN0LCBpbnRlbF9kcAo+ID4gPiAt Pm1zdF9tZ3IubXN0X3N0YXRlKTsKPiA+ID4gKwkJCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFsc2U7 Cj4gPiA+ICsJCQkJZHJtX2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50ZWxfZHAKPiA+ ID4gLT5tc3RfbWdyLAo+ID4gPiArCQkJCQkJCQlpbnRlbF9kcAo+ID4gPiAtPmlzX21zdCk7Cj4g PiA+ICsJCQkJZ290byBwdXRfcG93ZXI7Cj4gPiA+ICsJCQl9Cj4gPiA+ICAgCQl9Cj4gPiA+ICAg Cj4gPiA+ICAgCQlpZiAoIWludGVsX2RwLT5pc19tc3QpIHsKPiA+ID4gQEAgLTUwNTYsMTQgKzUw ODEsNiBAQCBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydAo+ID4g PiAqaW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4gPiA+ICAgCj4gPiA+ICAgCXJldCA9 IElSUV9IQU5ETEVEOwo+ID4gPiAgIAo+ID4gPiAtCWdvdG8gcHV0X3Bvd2VyOwo+ID4gPiAtbXN0 X2ZhaWw6Cj4gPiA+IC0JLyogaWYgd2Ugd2VyZSBpbiBNU1QgbW9kZSwgYW5kIGRldmljZSBpcyBu b3QgdGhlcmUgZ2V0IG91dCBvZiBNU1QKPiA+ID4gbW9kZSAqLwo+ID4gPiAtCWlmIChpbnRlbF9k cC0+aXNfbXN0KSB7Cj4gPiA+IC0JCURSTV9ERUJVR19LTVMoIk1TVCBkZXZpY2UgbWF5IGhhdmUg ZGlzYXBwZWFyZWQgJWQgdnMKPiA+ID4gJWRcbiIsCj4gPiA+IGludGVsX2RwLT5pc19tc3QsIGlu dGVsX2RwLT5tc3RfbWdyLm1zdF9zdGF0ZSk7Cj4gPiA+IC0JCWludGVsX2RwLT5pc19tc3QgPSBm YWxzZTsKPiA+ID4gLQkJZHJtX2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgmaW50ZWxfZHAt Pm1zdF9tZ3IsCj4gPiA+IGludGVsX2RwCj4gPiA+IC0+aXNfbXN0KTsKPiA+ID4gLQl9Cj4gPiA+ ICAgcHV0X3Bvd2VyOgo+ID4gPiAgIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwg cG93ZXJfZG9tYWluKTsKPiA+ID4gICAKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK