From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: [PATCH v2 2/9] pci/linux: minor cleanup Date: Fri, 29 Jan 2016 15:49:06 +0100 Message-ID: <1454078953-23744-3-git-send-email-david.marchand@6wind.com> References: <1453476464-31767-1-git-send-email-david.marchand@6wind.com> <1454078953-23744-1-git-send-email-david.marchand@6wind.com> Cc: viktorin@rehivetech.com To: dev@dpdk.org Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id DC243C6AC for ; Fri, 29 Jan 2016 15:49:20 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id p63so71750129wmp.1 for ; Fri, 29 Jan 2016 06:49:20 -0800 (PST) In-Reply-To: <1454078953-23744-1-git-send-email-david.marchand@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Those are the only fields that are explicitly set to 0 while the global dev pointer is set to 0 a few lines before. Signed-off-by: David Marchand --- lib/librte_eal/linuxapp/eal/eal_pci.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c index d9d6de7..6751b48 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c @@ -308,7 +308,6 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus, dev->id.subsystem_device_id = (uint16_t)tmp; /* get max_vfs */ - dev->max_vfs = 0; snprintf(filename, sizeof(filename), "%s/max_vfs", dirname); if (!access(filename, F_OK) && eal_parse_sysfs_value(filename, &tmp) == 0) @@ -323,12 +322,8 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus, } /* get numa node */ - snprintf(filename, sizeof(filename), "%s/numa_node", - dirname); - if (access(filename, R_OK) != 0) { - /* if no NUMA support, set default to 0 */ - dev->numa_node = 0; - } else { + snprintf(filename, sizeof(filename), "%s/numa_node", dirname); + if (!access(filename, R_OK)) { if (eal_parse_sysfs_value(filename, &tmp) < 0) { free(dev); return -1; -- 1.9.1