From: Johannes Berg <johannes@sipsolutions.net>
To: Peter Zijlstra <peterz@infradead.org>, Baozeng <sploving1@gmail.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
syzkaller@googlegroups.com, linux-wireless@vger.kernel.org
Subject: Re: sched/core: WARNING in __might_sleep
Date: Mon, 01 Feb 2016 12:26:06 +0100 [thread overview]
Message-ID: <1454325966.3211.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20160201111313.GQ6357@twins.programming.kicks-ass.net>
On Mon, 2016-02-01 at 12:13 +0100, Peter Zijlstra wrote:
>
> Yeah, from the rfkill code, which you failed to CC.
Thanks Peter :)
> In any case, this is a fail in the rfkill code, which should be
> sorted
> with the below patch (but the rfkill people should double check), and
> ideally they'd use list_empty_careful() instead of the mutex, but I
> don't know their code well enough to say if that's safe or not.
Even list_empty() is fine in this case since we go and recheck it
anyway in the calling loop, while the mutex is held.
I have commit 6736fde9672f on its way to mainline.
johannes
next prev parent reply other threads:[~2016-02-01 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAP=GMUGr=qHO4uh9v=ZmEhGu1GTBGzmuZNQ+_Ds38yRXq1ZXPA@mail.gmail.com>
2016-02-01 11:13 ` sched/core: WARNING in __might_sleep Peter Zijlstra
2016-02-01 11:26 ` Johannes Berg [this message]
2016-02-01 11:44 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454325966.3211.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sploving1@gmail.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.