From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQDBc-0004Vm-3u for qemu-devel@nongnu.org; Mon, 01 Feb 2016 07:02:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQDBX-0003Gg-IU for qemu-devel@nongnu.org; Mon, 01 Feb 2016 07:02:27 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:16453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQDBW-0003FZ-S2 for qemu-devel@nongnu.org; Mon, 01 Feb 2016 07:02:23 -0500 From: zhanghailiang Date: Mon, 1 Feb 2016 20:01:16 +0800 Message-ID: <1454328077-18820-4-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1454328077-18820-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1454328077-18820-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v3 3/4] filter-buffer: Accept zero interval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: zhanghailiang , zhangchen.fnst@cn.fujitsu.com, jasowang@redhat.com, dgilbert@redhat.com, hongyang.yang@easystack.cn We may want to accept zero interval when VM FT solutions like MC or COLO use this filter to release packets on demand. Signed-off-by: zhanghailiang Reviewed-by: Yang Hongyang --- net/filter-buffer.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/net/filter-buffer.c b/net/filter-buffer.c index 57be149..12e0c87 100644 --- a/net/filter-buffer.c +++ b/net/filter-buffer.c @@ -103,16 +103,6 @@ static void filter_buffer_setup(NetFilterState *nf, Error **errp) { FilterBufferState *s = FILTER_BUFFER(nf); - /* - * We may want to accept zero interval when VM FT solutions like MC - * or COLO use this filter to release packets on demand. - */ - if (!s->interval) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval", - "a non-zero interval"); - return; - } - s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf); if (s->interval) { timer_init_us(&s->release_timer, QEMU_CLOCK_VIRTUAL, -- 1.8.3.1