All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 2/4] core/gatt-client: Fix not being able to cancel notifications
Date: Mon,  1 Feb 2016 16:13:20 +0200	[thread overview]
Message-ID: <1454336002-4954-2-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1454336002-4954-1-git-send-email-luiz.dentz@gmail.com>

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

While the notification is still in process notifying flag wont be set but
it shall still be possible to cancel it otherwise the client has to wait
until the remote respond which can take a lot of time (up to 30 seconds).
---
 src/gatt-client.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/gatt-client.c b/src/gatt-client.c
index 39f6646..b4ca3b6 100644
--- a/src/gatt-client.c
+++ b/src/gatt-client.c
@@ -1205,9 +1205,6 @@ static DBusMessage *characteristic_stop_notify(DBusConnection *conn,
 	const char *sender = dbus_message_get_sender(msg);
 	struct notify_client *client;
 
-	if (!chrc->notifying)
-		return btd_error_failed(msg, "Not notifying");
-
 	client = queue_remove_if(chrc->notify_clients, match_notify_sender,
 							(void *) sender);
 	if (!client)
-- 
2.5.0


  reply	other threads:[~2016-02-01 14:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 14:13 [PATCH BlueZ 1/4] shared/gatt-client: Fix not resetting request id Luiz Augusto von Dentz
2016-02-01 14:13 ` Luiz Augusto von Dentz [this message]
2016-02-01 14:13 ` [PATCH BlueZ 3/4] shared/gatt-client: Fix bogus asserts Luiz Augusto von Dentz
2016-02-01 14:13 ` [PATCH BlueZ 4/4] shared/gatt-client: Fix crash unregistering notification Luiz Augusto von Dentz
2016-02-07 16:01 ` [PATCH BlueZ 1/4] shared/gatt-client: Fix not resetting request id Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454336002-4954-2-git-send-email-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.