All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <oss@buserror.net>
To: Brian Norris <computersforpeace@gmail.com>,
	Raghav Dogra <raghav@freescale.com>
Cc: linux-mtd@lists.infradead.org, prabhakar@freescale.com,
	Jaiprakash Singh <b44839@freescale.com>
Subject: Re: [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers
Date: Mon, 01 Feb 2016 16:27:58 -0600	[thread overview]
Message-ID: <1454365678.2486.19.camel@buserror.net> (raw)
In-Reply-To: <20160201184145.GH19540@google.com>

On Mon, 2016-02-01 at 10:41 -0800, Brian Norris wrote:
> Hi Raghav,
> 
> On Wed, Dec 16, 2015 at 04:12:09PM +0530, Raghav Dogra wrote:
> > IFC has two set of registers viz FCM (Flash control machine)
> > aka global and run time registers. These set are defined in two
> > memory map PAGES. Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0
> > PAGE size is 64KB
> 
> So...this patch is adding new hardware support? It's not immediately
> clear from the patch description. Perhaps that could use some work?
> 
> > Signed-off-by: Jaiprakash Singh <b44839@freescale.com>
> > Signed-off-by: Raghav Dogra <raghav@freescale.com>
> > ---
> >  drivers/memory/fsl_ifc.c        | 37 ++++++++++-----------
> >  drivers/mtd/nand/fsl_ifc_nand.c | 72 ++++++++++++++++++++++--------------
> > -----
> >  include/linux/fsl_ifc.h         | 45 +++++++++++++++++---------
> 
> Who merges changes for the drivers/memory/ portions anyway? Is there a
> maintainer?

Whoever makes sense for the particular patch.

>  Or should I be taking these, since it touches drivers/mtd/
> enough? If so, can I get an ack from a Freescale maintainer?

Acked-by: Scott Wood <oss@buserror.net>

...assuming the sparse warning and the struct name (see my other mail) are
fixed.

-Scott

  reply	other threads:[~2016-02-01 22:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 10:42 [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers Raghav Dogra
2016-02-01 18:41 ` Brian Norris
2016-02-01 22:27   ` Scott Wood [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-02-01 10:46 [PATCH 1/3] driver/memory: Removal of deprecated NO_IRQ Raghav Dogra
2016-02-01 10:46 ` [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers Raghav Dogra
2016-02-01 19:41   ` Li Yang
2016-02-01 20:43     ` Brian Norris
2016-02-01 22:26   ` Scott Wood
2015-12-16 10:40 Raghav Dogra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454365678.2486.19.camel@buserror.net \
    --to=oss@buserror.net \
    --cc=b44839@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=prabhakar@freescale.com \
    --cc=raghav@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.