All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
To: netdev@vger.kernel.org
Subject: [PATCH net-next 1/8] be2net: return error status from be_set_phys_id()
Date: Tue,  2 Feb 2016 15:50:28 +0530	[thread overview]
Message-ID: <1454408435-11575-2-git-send-email-sriharsha.basavapatna@broadcom.com> (raw)
In-Reply-To: <1454408435-11575-1-git-send-email-sriharsha.basavapatna@broadcom.com>

From: Suresh Reddy <suresh.reddy@broadcom.com>

be_set_phys_id() returns 0 to ethtool when the command fails in the FW.

This patch fixes the set_phys_id() to return -EIO in case the FW cmd fails.

Signed-off-by: Suresh Reddy <suresh.reddy@broadcom.com>
Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
---
 drivers/net/ethernet/emulex/benet/be_ethtool.c | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
index a19ac44..2ff6916 100644
--- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
+++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
@@ -720,29 +720,32 @@ static int be_set_phys_id(struct net_device *netdev,
 			  enum ethtool_phys_id_state state)
 {
 	struct be_adapter *adapter = netdev_priv(netdev);
+	int status = 0;
 
 	switch (state) {
 	case ETHTOOL_ID_ACTIVE:
-		be_cmd_get_beacon_state(adapter, adapter->hba_port_num,
-					&adapter->beacon_state);
-		return 1;	/* cycle on/off once per second */
+		status = be_cmd_get_beacon_state(adapter, adapter->hba_port_num,
+						 &adapter->beacon_state);
+		if (status)
+			return be_cmd_status(status);
+		return 1;       /* cycle on/off once per second */
 
 	case ETHTOOL_ID_ON:
-		be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,
-					BEACON_STATE_ENABLED);
+		status = be_cmd_set_beacon_state(adapter, adapter->hba_port_num,
+						 0, 0, BEACON_STATE_ENABLED);
 		break;
 
 	case ETHTOOL_ID_OFF:
-		be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,
-					BEACON_STATE_DISABLED);
+		status = be_cmd_set_beacon_state(adapter, adapter->hba_port_num,
+						 0, 0, BEACON_STATE_DISABLED);
 		break;
 
 	case ETHTOOL_ID_INACTIVE:
-		be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,
-					adapter->beacon_state);
+		status = be_cmd_set_beacon_state(adapter, adapter->hba_port_num,
+						 0, 0, adapter->beacon_state);
 	}
 
-	return 0;
+	return be_cmd_status(status);
 }
 
 static int be_set_dump(struct net_device *netdev, struct ethtool_dump *dump)
-- 
2.3.0.rc2

  reply	other threads:[~2016-02-02 10:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 10:20 [PATCH net-next 0/8] be2net patch-set Sriharsha Basavapatna
2016-02-02 10:20 ` Sriharsha Basavapatna [this message]
2016-02-02 10:20 ` [PATCH net-next 2/8] be2net: check for INSUFFICIENT_PRIVILEGES error Sriharsha Basavapatna
2016-02-02 10:20 ` [PATCH net-next 3/8] be2net: Fix be_vlan_rem_vid() to check vlan id being removed Sriharsha Basavapatna
2016-02-02 10:20 ` [PATCH net-next 4/8] be2net: SRIOV Queue distribution should factor in EQ-count of VFs Sriharsha Basavapatna
2016-02-02 14:30   ` Sergei Shtylyov
2016-02-02 15:41     ` Sriharsha Basavapatna
2016-02-02 16:41       ` Sergei Shtylyov
2016-02-02 10:20 ` [PATCH net-next 5/8] be2net: Don't run ethtool self-tests for VFs Sriharsha Basavapatna
2016-02-02 10:20 ` [PATCH net-next 6/8] benet: Fix Lancer error recovery Sriharsha Basavapatna
2016-02-02 10:20 ` [PATCH net-next 7/8] benet: Add retry in case of error recovery failure Sriharsha Basavapatna
2016-02-02 10:20 ` [PATCH net-next 8/8] benet: Fix interval calculation in interrupt moderation Sriharsha Basavapatna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454408435-11575-2-git-send-email-sriharsha.basavapatna@broadcom.com \
    --to=sriharsha.basavapatna@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.