From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH 04/12] drm/i915/lrc: Do not wait atomically when stopping engines
Date: Tue, 2 Feb 2016 11:06:22 +0000 [thread overview]
Message-ID: <1454411190-15721-5-git-send-email-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <1454411190-15721-1-git-send-email-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
I do not see that this needs to be done atomically and up to
one second is quite a long time to busy loop.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/intel_lrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 3a03646e343d..3ca7f48a418b 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1049,7 +1049,7 @@ void intel_logical_ring_stop(struct intel_engine_cs *ring)
/* TODO: Is this correct with Execlists enabled? */
I915_WRITE_MODE(ring, _MASKED_BIT_ENABLE(STOP_RING));
- if (wait_for_atomic((I915_READ_MODE(ring) & MODE_IDLE) != 0, 1000)) {
+ if (wait_for((I915_READ_MODE(ring) & MODE_IDLE) != 0, 1000)) {
DRM_ERROR("%s :timed out trying to stop ring\n", ring->name);
return;
}
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-02-02 11:06 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 11:06 [PATCH 00/12] Misc locking fixes and GEM debugging Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 01/12] drm/i915: Add wait_for_us Tvrtko Ursulin
2016-02-02 11:57 ` Chris Wilson
2016-02-02 14:04 ` Tvrtko Ursulin
2016-02-02 15:43 ` Chris Wilson
2016-02-02 13:35 ` Dave Gordon
2016-02-02 13:58 ` Tvrtko Ursulin
2016-02-02 14:44 ` [PATCH v2 " Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 02/12] drm/i915: Do not wait atomically for display clocks Tvrtko Ursulin
2016-02-02 12:00 ` Chris Wilson
2016-02-02 14:08 ` Dave Gordon
2016-02-02 15:39 ` Chris Wilson
2016-02-02 11:06 ` [PATCH 03/12] drm/i915/guc: Do not wait for firmware load atomically Tvrtko Ursulin
2016-02-02 14:13 ` Dave Gordon
2016-02-02 11:06 ` Tvrtko Ursulin [this message]
2016-02-02 11:06 ` [PATCH 05/12] drm/i915: Kconfig for extra driver debugging Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 06/12] drm/i915: Do not lie about atomic wait granularity Tvrtko Ursulin
2016-02-02 12:29 ` Chris Wilson
2016-02-02 14:45 ` [PATCH v3 " Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 07/12] drm/i915: GEM operations need to be done under the big lock Tvrtko Ursulin
2016-02-02 12:05 ` Chris Wilson
2016-02-02 14:46 ` [PATCH v4 " Tvrtko Ursulin
2016-02-02 15:49 ` Chris Wilson
2016-02-11 10:13 ` Chris Wilson
2016-02-15 16:09 ` Daniel Vetter
2016-02-11 10:07 ` [PATCH " Chris Wilson
2016-02-02 11:06 ` [PATCH 08/12] drm/i915: Fix struct mutex vs. RPS lock inversion Tvrtko Ursulin
2016-02-02 13:16 ` Chris Wilson
2016-02-02 14:13 ` Tvrtko Ursulin
2016-02-02 14:48 ` Chris Wilson
2016-02-02 14:46 ` [PATCH v3 " Tvrtko Ursulin
2016-02-11 10:06 ` Chris Wilson
2016-02-02 11:06 ` [PATCH 09/12] drm/i915/ilk: Move register read under spinlock Tvrtko Ursulin
2016-02-02 12:01 ` Chris Wilson
2016-02-02 11:06 ` [PATCH 10/12] drm/i915: Introduce dedicated object VMA iterator Tvrtko Ursulin
2016-02-02 11:36 ` Chris Wilson
2016-02-02 12:10 ` Tvrtko Ursulin
2016-02-02 12:58 ` Chris Wilson
2016-02-02 13:56 ` Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 11/12] drm/i915: Introduce dedicated safe " Tvrtko Ursulin
2016-02-02 11:06 ` [PATCH 12/12] drm/i915: Add BKL asserts to get page helpers Tvrtko Ursulin
2016-02-02 11:39 ` Chris Wilson
2016-02-02 12:02 ` Tvrtko Ursulin
2016-02-02 11:22 ` ✓ Fi.CI.BAT: success for Misc locking fixes and GEM debugging Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454411190-15721-5-git-send-email-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.