From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933413AbcBBRym (ORCPT ); Tue, 2 Feb 2016 12:54:42 -0500 Received: from smtprelay0240.hostedemail.com ([216.40.44.240]:52297 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932990AbcBBRyk (ORCPT ); Tue, 2 Feb 2016 12:54:40 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4470:5007:6261:6742:9025:10004:10400:10848:11232:11658:11783:11914:12043:12517:12519:12740:13069:13311:13357:13894:14659:21080:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: front46_628244af5371f X-Filterd-Recvd-Size: 2092 Message-ID: <1454433698.7291.24.camel@perches.com> Subject: Re: [PATCH] kernel/fork.c: use sizeof() instead of sizeof From: Joe Perches To: Al Viro Cc: Ingo Molnar , Wei Tang , akpm@linux-foundation.org, peterz@infradead.org, tj@kernel.org, kirill.shutemov@linux.intel.com, jason.low2@hp.com, xypron.glpk@gmx.de, oleg@redhat.com, koct9i@gmail.com, josh@joshtriplett.org, ebiederm@xmission.com, cyphar@cyphar.com, linux-kernel@vger.kernel.org In-Reply-To: <20160202171146.GQ17997@ZenIV.linux.org.uk> References: <1454399594-14307-1-git-send-email-tangwei@cmss.chinamobile.com> <20160202091118.GB30393@gmail.com> <20160202154531.GO17997@ZenIV.linux.org.uk> <1454432536.7291.18.camel@perches.com> <20160202171146.GQ17997@ZenIV.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-1" Date: Tue, 02 Feb 2016 09:21:38 -0800 Mime-Version: 1.0 X-Mailer: Evolution 3.18.3-1ubuntu1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-02-02 at 17:11 +0000, Al Viro wrote: > On Tue, Feb 02, 2016 at 09:02:16AM -0800, Joe Perches wrote: > > On Tue, 2016-02-02 at 15:45 +0000, Al Viro wrote: > > > On Tue, Feb 02, 2016 at 10:11:18AM +0100, Ingo Molnar wrote: > > > > * Wei Tang wrote: > > [] > > > > > WARNING: sizeof sig->rlim should be sizeof(sig->rlim) > > [] > > > > If anyone feels strongly about accepting such patches, then the right solution is  > > > > to create a Coccinelle semantic patch to run over the whole kernel and get over  > > > > with the churn once and for all. > > > > > > That, or a single patch taking that piece of idiocy out of checkpatch.pl... > > > > https://lkml.org/lkml/2012/7/11/103 > > Umm...  Matter of taste, really On that I can agree.  Idiocy rather less so.