From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: bitbake-devel <bitbake-devel@lists.openembedded.org>
Cc: openembedded-architecture
<openembedded-architecture@lists.openembedded.org>
Subject: [PATCH] data_smart: Drop default expand=False to getVar [API change]
Date: Tue, 02 Feb 2016 23:55:40 +0000 [thread overview]
Message-ID: <1454457340.27087.143.camel@linuxfoundation.org> (raw)
At some point in the future, getVar should expand by default. To get
there from the current position, we need a period of time where the
expand parameter is mandatory.
This patch starts that process. Clear errors will result from any code
which doesn't provide this. Layers can be fixed with an expression
like:
sed -e 's:\(\.getVar([^,()]*, [^,()]*\)):\1, False):g' -i `grep -ril getVar *`
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py
index 8c3e9ef..79bec1b 100644
--- a/bitbake/lib/bb/data_smart.py
+++ b/bitbake/lib/bb/data_smart.py
@@ -566,7 +566,7 @@ class DataSmart(MutableMapping):
if len(shortvar) == 0:
override = None
- def getVar(self, var, expand=False, noweakdefault=False, parsing=False):
+ def getVar(self, var, expand, noweakdefault=False, parsing=False):
return self.getVarFlag(var, "_content", expand, noweakdefault, parsing)
def renameVar(self, key, newkey, **loginfo):
next reply other threads:[~2016-02-02 23:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 23:55 Richard Purdie [this message]
2016-02-03 10:11 ` [Openembedded-architecture] [PATCH] data_smart: Drop default expand=False to getVar [API change] Otavio Salvador
2016-02-03 11:22 ` Richard Purdie
2016-02-03 15:06 ` Martin Jansa
2016-02-03 16:22 ` Richard Purdie
2016-02-03 16:29 ` Christopher Larson
2016-02-03 16:38 ` Richard Purdie
2016-02-03 16:52 ` Christopher Larson
2016-02-03 16:43 ` Otavio Salvador
2016-02-06 6:38 ` Paul Eggleton
2016-02-06 9:22 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454457340.27087.143.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=openembedded-architecture@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.