From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753658AbcBCJmV (ORCPT ); Wed, 3 Feb 2016 04:42:21 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:1177 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbcBCJmT (ORCPT ); Wed, 3 Feb 2016 04:42:19 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 03 Feb 2016 01:42:20 -0800 From: Laxman Dewangan To: , , , CC: , , , Laxman Dewangan Subject: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Date: Wed, 3 Feb 2016 15:00:47 +0530 Message-ID: <1454491848-26551-5-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1454491848-26551-1-git-send-email-ldewangan@nvidia.com> References: <1454491848-26551-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is different RTC I2C address for RTC block in MAX77686. Driver is creating dummy i2c client for this address to access the register of this IP block. As there is no need to get any data from this rtc i2c client, it is not required to set client data for this i2c client. Suggested-by: Krzysztof Kozlowski Signed-off-by: Laxman Dewangan CC: Krzysztof Kozlowski CC: Javier Martinez Canillas --- This is new in this series based on review comment from V1. drivers/mfd/max77686.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index d959ebb..bda6fd7 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -277,7 +277,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c, "Failed to allocate I2C device for RTC\n"); return -ENODEV; } - i2c_set_clientdata(max77686->rtc, max77686); max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc, -- 2.1.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com. [216.228.121.65]) by gmr-mx.google.com with ESMTPS id tn7si768336pac.1.2016.02.03.01.42.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Feb 2016 01:42:19 -0800 (PST) From: Laxman Dewangan To: , , , CC: , , , Laxman Dewangan Subject: [rtc-linux] [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Date: Wed, 3 Feb 2016 15:00:47 +0530 Message-ID: <1454491848-26551-5-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1454491848-26551-1-git-send-email-ldewangan@nvidia.com> References: <1454491848-26551-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , There is different RTC I2C address for RTC block in MAX77686. Driver is creating dummy i2c client for this address to access the register of this IP block. As there is no need to get any data from this rtc i2c client, it is not required to set client data for this i2c client. Suggested-by: Krzysztof Kozlowski Signed-off-by: Laxman Dewangan CC: Krzysztof Kozlowski CC: Javier Martinez Canillas --- This is new in this series based on review comment from V1. drivers/mfd/max77686.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index d959ebb..bda6fd7 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -277,7 +277,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c, "Failed to allocate I2C device for RTC\n"); return -ENODEV; } - i2c_set_clientdata(max77686->rtc, max77686); max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc, -- 2.1.4 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.