From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757203AbcBCLif (ORCPT ); Wed, 3 Feb 2016 06:38:35 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:45907 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754923AbcBCLid (ORCPT ); Wed, 3 Feb 2016 06:38:33 -0500 X-AuditID: cbfee61a-f79266d000003652-ca-56b1e6b8d135 From: Robert Baldyga To: balbi@ti.com, johnyoun@synopsys.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com, Robert Baldyga Subject: [PATCH v2 4/5] usb: dwc2: gadget: remove dead code from dwc2_hsotg_ep_enable() Date: Wed, 03 Feb 2016 12:36:33 +0100 Message-id: <1454499394-4610-5-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1454499394-4610-1-git-send-email-r.baldyga@samsung.com> References: <1454499394-4610-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFLMWRmVeSWpSXmKPExsVy+t9jAd0dzzaGGXy7w2OxccZ6VouD9+st mhevZ7PYffoSo8XlXXPYLBYta2W2WHvkLrvFg8M72R04PPbPXcPu0bdlFaPHlv2fGT2O39jO 5PF5k1wAaxSXTUpqTmZZapG+XQJXxo63/9kLvnBWzN79kamB8Sd7FyMHh4SAicSDRSpdjJxA ppjEhXvr2boYuTiEBJYySmx90sAI4fxklLi1bSojSBWbgI7Elu8TwGwRAXWJKXt6WUCKmAW2 M0o0PNwNNlVYIFLi7cUakBoWAVWJ+V+esIDYvAIuEg9+drFBbJOTOHlsMiuIzSngKvH5+Qcm EFsIqObPnBPsExh5FzAyrGKUSC1ILihOSs81zEst1ytOzC0uzUvXS87P3cQIDrFnUjsYD+5y P8QowMGoxMPL8GNDmBBrYllxZe4hRgkOZiUR3qt3N4YJ8aYkVlalFuXHF5XmpBYfYpTmYFES 5338f12YkEB6YklqdmpqQWoRTJaJg1OqgdF4kw1vTXn9dpFLJ3ZJS1+xntCr7uDhWbPJw8bS uvJ0YdStupzd/49ac4TNbwtYZNR/l+drQvu9GubX6ZYcG1kvPXj7SPXwBFm9DeVv9tirZLFL T5kwZ82Kg588Z3y/uFSgpXLhl9Qz7RO51j+aGLTpw8sEi7j9L4XNVdOXy+fVNOvZCIjNXqbE UpyRaKjFXFScCAAB84VqLQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since FIFO is always freed in dwc2_hsotg_ep_disable(), ep->fifo_index is always 0 in dwc2_hsotg_ep_enable(), hence code inside if() block is never executed. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index f01a936..8f9d45b 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2702,22 +2702,11 @@ static int dwc2_hsotg_ep_enable(struct usb_ep *ep, break; } - /* If fifo is already allocated for this ep */ - if (hs_ep->fifo_index) { - size = hs_ep->ep.maxpacket * hs_ep->mc; - /* If bigger fifo is required deallocate current one */ - if (size > hs_ep->fifo_size) { - hsotg->fifo_map &= ~(1 << hs_ep->fifo_index); - hs_ep->fifo_index = 0; - hs_ep->fifo_size = 0; - } - } - /* * if the hardware has dedicated fifos, we must give each IN EP * a unique tx-fifo even if it is non-periodic. */ - if (dir_in && hsotg->dedicated_fifos && !hs_ep->fifo_index) { + if (dir_in && hsotg->dedicated_fifos) { u32 fifo_index = 0; u32 fifo_size = UINT_MAX; size = hs_ep->ep.maxpacket*hs_ep->mc; -- 1.9.1