Re: [PATCH 2/3] Add a weekly coverity flight

From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH 2/3] Add a weekly coverity flight
Date: Wed, 3 Feb 2016 12:46:24 +0000	[thread overview]
Message-ID: <1454503584.25207.114.camel@citrix.com> (raw)
In-Reply-To: <22193.61118.183626.135765@mariner.uk.xensource.com>

On Wed, 2016-02-03 at 12:12 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH 2/3] Add a weekly coverity flight"):
> > In my experiments the curl command took ~35 minutes to complete (rate
> > in the 100-200k range). Not sure if this is a problem. Note that curl
> > is run on the controller (via system_checked) and consequently has no
> > timeout etc.
> 
> Can you use curl's builtin timeouts, or wrap it in alarm() ?
> Otherwise I think it is possible for this to become wedged
> indefinitely and need manual un-wedging.

I added --max-time 3600.

> AFAICT during the curl the only lock or resource which is held is the
> build host share.  I think we can live with that.

There's the per-branch lock too, FWIW.

> > Deployment notes:
> >  - Put cov-analysis-linux64-7.7.0.4.tar.gz in the Images
> >    directory. DONE in COLO
> >  - Populate $HOME/.xen-osstest/coverity-secret with the token
> >    DONE in COLO
> >  - Populate xen.git#coverity-scanned with an initial baseline, update
> >    ap-fetch-version-old to refer to it instead of master.
> ...
> > +coverity)
> > +	#XXX doesn't exist yet, use master for now
> > repo_tree_rev_fetch_git xen $TREE_XEN coverity-scanned $LOCALREV_XEN
> 
> This XXX is out of date ?  And so the code should be fixed ?

coverity-scanned doesn't exist in xen.git yet, so for now this is still
correct, its the subject of the 3rd deployment note.

I'd be happy to push 9937763265d9597e5f2439249b16d995842cdf0f (the subject
of my recent adhoc test) to that new branch in xen.git right away though if
you agree and then update this code.

> > +	case $branch in
> > +	    coverity)
> > +		if [ "x$TREE_COVERITY" = x ]; then
> > +		    export TREE_COVERITY=$TREE_XEN
> > +		fi
> > +		if [ "x$REVISION_COVERITY" = x ]; then
> > +		    determine_version REVISION_COVERITY coverity
> > COVERITY
> > +		    export REVISION_COVERITY
> > +		fi
> > +		NEW_REVISION=$REVISION_COVERITY
> 
> I'm not sure why these variables are all REVISION_COVERITY rather than
> REVISION_XEN.

IIRC I had trouble getting cr-daily-branch's determine_version to populate
REVISION_XEN using values from "ap-fetch-version* coverity", maybe due to
the [ "x$tbranch" = "x$branch" ] ? 

or else there was some other wrinkle around that area.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel