From: Fabio Estevam <fabio.estevam@nxp.com>
To: <herbert@gondor.apana.org.au>
Cc: <s.trumtrar@pengutronix.de>, <marex@denx.de>,
<linux@arm.linux.org.uk>, <linux-crypto@vger.kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: [PATCH v3 1/3] crypto: sahara - remove unneeded mutex in the exported state
Date: Wed, 3 Feb 2016 10:46:50 -0200 [thread overview]
Message-ID: <1454503612-21344-1-git-send-email-fabio.estevam@nxp.com> (raw)
As pointed out by Herbert Xu we should not include the mutex in the
exported state, so let's just get rid of it.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/crypto/sahara.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 6c4f91c..7e8147d 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -182,7 +182,6 @@ struct sahara_sha_reqctx {
u8 buf[SAHARA_MAX_SHA_BLOCK_SIZE];
u8 rembuf[SAHARA_MAX_SHA_BLOCK_SIZE];
u8 context[SHA256_DIGEST_SIZE + 4];
- struct mutex mutex;
unsigned int mode;
unsigned int digest_size;
unsigned int context_size;
@@ -1096,7 +1095,6 @@ static int sahara_sha_enqueue(struct ahash_request *req, int last)
if (!req->nbytes && !last)
return 0;
- mutex_lock(&rctx->mutex);
rctx->last = last;
if (!rctx->active) {
@@ -1109,7 +1107,6 @@ static int sahara_sha_enqueue(struct ahash_request *req, int last)
mutex_unlock(&dev->queue_mutex);
wake_up_process(dev->kthread);
- mutex_unlock(&rctx->mutex);
return ret;
}
@@ -1137,8 +1134,6 @@ static int sahara_sha_init(struct ahash_request *req)
rctx->context_size = rctx->digest_size + 4;
rctx->active = 0;
- mutex_init(&rctx->mutex);
-
return 0;
}
--
1.9.1
next reply other threads:[~2016-02-03 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 12:46 Fabio Estevam [this message]
2016-02-03 12:46 ` [PATCH v3 2/3] crypto: sahara - avoid needlessly saving and restoring sahara_ctx Fabio Estevam
2016-02-03 12:46 ` [PATCH v3 3/3] crypto: sahara - fill the statesize field Fabio Estevam
2016-02-06 7:48 ` [PATCH v3 1/3] crypto: sahara - remove unneeded mutex in the exported state Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454503612-21344-1-git-send-email-fabio.estevam@nxp.com \
--to=fabio.estevam@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marex@denx.de \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.