From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965570AbcBCSaj (ORCPT ); Wed, 3 Feb 2016 13:30:39 -0500 Received: from smtprelay0086.hostedemail.com ([216.40.44.86]:33267 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964967AbcBCSah (ORCPT ); Wed, 3 Feb 2016 13:30:37 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:196:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3876:3877:4321:4385:5007:6114:6261:6642:10004:10400:10450:10455:10848:11026:11232:11658:11783:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:13894:14659:19904:19999:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: year91_21f5f6efd6640 X-Filterd-Recvd-Size: 2081 Message-ID: <1454524232.7291.105.camel@perches.com> Subject: Re: [PATCH] ext4: add a line break for proc mb_groups display From: Joe Perches To: "Darrick J. Wong" , Huaitong Han Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 03 Feb 2016 10:30:32 -0800 In-Reply-To: <20160203181356.GA5842@birch.djwong.org> References: <1454505546-4875-1-git-send-email-huaitong.han@intel.com> <20160203181356.GA5842@birch.djwong.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > This patch adds a line break for proc mb_groups display. Using 2 lines for output might break any existing users. Are there any? > > > > Signed-off-by: Huaitong Han > > --- > >  fs/ext4/mballoc.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > > index 61eaf74..4424b7b 100644 > > --- a/fs/ext4/mballoc.c > > +++ b/fs/ext4/mballoc.c > > @@ -2285,7 +2285,7 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, void *v) > >   if (group == 0) > >   seq_puts(seq, "#group: free  frags first [" > >         " 2^0   2^1   2^2   2^3   2^4   2^5   2^6  " > > -       " 2^7   2^8   2^9   2^10  2^11  2^12  2^13  ]"); > > +       " 2^7   2^8   2^9   2^10  2^11  2^12  2^13  ]\n"); > > Oh, heh. > > Reviewed-by: Darrick J. Wong > > --D > > >   > >   i = (sb->s_blocksize_bits + 2) * sizeof(sg.info.bb_counters[0]) + > >   sizeof(struct ext4_group_info);