From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH 1/3] eal/x86: fix build with clang for old AVX Date: Wed, 3 Feb 2016 19:56:37 +0100 Message-ID: <1454525799-25552-2-git-send-email-thomas.monjalon@6wind.com> References: <1454525799-25552-1-git-send-email-thomas.monjalon@6wind.com> To: dev@dpdk.org Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 68CB595D9 for ; Wed, 3 Feb 2016 19:58:00 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id 128so179725290wmz.1 for ; Wed, 03 Feb 2016 10:58:00 -0800 (PST) In-Reply-To: <1454525799-25552-1-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When configuring RTE_MACHINE to "default", rte_memcpy implementation is the default one (old AVX). In this code, clang raises a warning thanks to -Wsometimes-uninitialized: rte_memcpy.h:838:6: error: variable 'srcofs' is used uninitialized whenever 'if' condition is false if (dstofss > 0) { ^~~~~~~~~~~ rte_memcpy.h:849:6: note: uninitialized use occurs here if (srcofs == 0) { ^~~~~~ It is fixed by initializing srcofs to 0. Fixes: 1ae817f9f887 ("eal/x86: tune memcpy for platforms without AVX512") Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h index 8e2c53c..5badfbc 100644 --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h @@ -739,7 +739,7 @@ rte_memcpy(void *dst, const void *src, size_t n) uintptr_t srcu = (uintptr_t)src; void *ret = dst; size_t dstofss; - size_t srcofs; + size_t srcofs = 0; /** * Copy less than 16 bytes -- 2.7.0