From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965477AbcBCTXu (ORCPT ); Wed, 3 Feb 2016 14:23:50 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34885 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965039AbcBCTXs (ORCPT ); Wed, 3 Feb 2016 14:23:48 -0500 Message-ID: <1454527426.7627.282.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH v3] net:Add sysctl_max_skb_frags From: Eric Dumazet To: Alexander Duyck Cc: Hans Westgaard Ry , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , Tom Herbert , Pablo Neira Ayuso , Eric Dumazet , Florian Westphal , Jiri Pirko , Alexander Duyck , Michal Hocko , Linus =?ISO-8859-1?Q?L=FCssing?= , Hannes Frederic Sowa , Herbert Xu , Tejun Heo , Andrew Morton , Alexey Kodanev , =?ISO-8859-1?Q?H=E5kon?= Bugge , open list , "open list:NETWORKING [GENERAL]" Date: Wed, 03 Feb 2016 11:23:46 -0800 In-Reply-To: References: <568F87AC.60405@oracle.com> <1454488017-8822-1-git-send-email-hans.westgaard.ry@oracle.com> <1454515628.7627.245.camel@edumazet-glaptop2.roam.corp.google.com> <1454522077.7627.264.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-02-03 at 10:24 -0800, Alexander Duyck wrote: > If this is only meant to be a performance modification and is only > really targeted at TCP TSO/GRO then all I ask is that we use a name > like tcp_max_gso_frags and relocate the sysctl to the TCP section. > Otherwise if we are actually going to try to scope this out on a wider > level and limit all frags which is what the name implies then the > patch set needs to make a better attempt at covering all cases where > it may apply. This is the goal. Other skb providers (like tun and af_packet) will also use this optional limit. I fail to see why Hans should send a complete patch series. We will send followup patches, as we always did. I will send the GRO change for example. So please keep a sysctl name _without_ TCP in it, it really has nothing to do with TCP. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v3] net:Add sysctl_max_skb_frags Date: Wed, 03 Feb 2016 11:23:46 -0800 Message-ID: <1454527426.7627.282.camel@edumazet-glaptop2.roam.corp.google.com> References: <568F87AC.60405@oracle.com> <1454488017-8822-1-git-send-email-hans.westgaard.ry@oracle.com> <1454515628.7627.245.camel@edumazet-glaptop2.roam.corp.google.com> <1454522077.7627.264.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Hans Westgaard Ry , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , Tom Herbert , Pablo Neira Ayuso , Eric Dumazet , Florian Westphal , Jiri Pirko , Alexander Duyck , Michal Hocko , Linus =?ISO-8859-1?Q?L=FCssing?= , Hannes Frederic Sowa , Herbert Xu , Tejun Heo , Andrew Morton , Alexey Kodanev , =?ISO-8859-1?Q?H=E5kon?= Bugge , open list , "open To: Alexander Duyck Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 2016-02-03 at 10:24 -0800, Alexander Duyck wrote: > If this is only meant to be a performance modification and is only > really targeted at TCP TSO/GRO then all I ask is that we use a name > like tcp_max_gso_frags and relocate the sysctl to the TCP section. > Otherwise if we are actually going to try to scope this out on a wider > level and limit all frags which is what the name implies then the > patch set needs to make a better attempt at covering all cases where > it may apply. This is the goal. Other skb providers (like tun and af_packet) will also use this optional limit. I fail to see why Hans should send a complete patch series. We will send followup patches, as we always did. I will send the GRO change for example. So please keep a sysctl name _without_ TCP in it, it really has nothing to do with TCP.