All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Huaitong Han <huaitong.han@intel.com>,
	tytso@mit.edu, adilger.kernel@dilger.ca,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: add a line break for proc mb_groups display
Date: Wed, 03 Feb 2016 11:38:33 -0800	[thread overview]
Message-ID: <1454528313.7291.115.camel@perches.com> (raw)
In-Reply-To: <20160203193233.GB5842@birch.djwong.org>

On Wed, 2016-02-03 at 11:32 -0800, Darrick J. Wong wrote:
> On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote:
> > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote:
> > > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote:
> > > > This patch adds a line break for proc mb_groups display.
> > 
> > Using 2 lines for output might break any existing users.
> > 
> > Are there any?
> 
> It's a multiline file if you have more than one blockgroup; this just makes it
> so that you don't have to special-case BG 0.

And existing scripts might do that now and might fail
to do properly after this change.

> IOW: mb_groups scripts already had to parse multiple lines, and most likely any
> script parsing it would inject a newline after the header.

I've no dog in this fight really.  I just wanted to make
it clear that this could cause existing scripts to fail.

proc output is supposed to be unchanging except maybe
adding new fields to existing lines.

Your choice.

cheers, Joe

  reply	other threads:[~2016-02-03 19:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 13:19 [PATCH] ext4: add a line break for proc mb_groups display Huaitong Han
2016-02-03 18:13 ` Darrick J. Wong
2016-02-03 18:30   ` Joe Perches
2016-02-03 19:32     ` Darrick J. Wong
2016-02-03 19:38       ` Joe Perches [this message]
2016-02-03 20:07         ` Darrick J. Wong
2016-02-03 20:07           ` Darrick J. Wong
2016-02-03 21:12           ` Andreas Dilger
2016-02-03 21:17             ` Joe Perches
2016-02-03 21:12 ` Andreas Dilger
2016-02-12  6:08   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454528313.7291.115.camel@perches.com \
    --to=joe@perches.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=darrick.wong@oracle.com \
    --cc=huaitong.han@intel.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.