From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from host.buserror.net (host.buserror.net [209.198.135.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CD5341A0018 for ; Sat, 6 Feb 2016 05:23:56 +1100 (AEDT) Message-ID: <1454696631.2486.33.camel@buserror.net> From: Scott Wood To: Li Yang Cc: Raghav Dogra , Brian Norris , linuxppc-dev , prabhakar.kushwaha@nxp.com, linux-mtd@lists.infradead.org, Jaiprakash Singh Date: Fri, 05 Feb 2016 12:23:51 -0600 In-Reply-To: References: <1454481372-10288-1-git-send-email-raghav@freescale.com> <1454635050.2486.25.camel@buserror.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Subject: Re: [PATCH] mtd/ifc: Add support for IFC controller version 2.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2016-02-05 at 12:05 -0600, Li Yang wrote: > On Thu, Feb 4, 2016 at 7:17 PM, Scott Wood wrote: > > On Thu, 2016-02-04 at 17:07 -0600, Li Yang wrote: > > > On Wed, Feb 3, 2016 at 12:36 AM, Raghav Dogra > > > wrote: > > > > The new IFC controller version 2.0 has a different memory map page. > > > > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB. > > > > This patch segregates the IFC global and runtime registers to > > > > appropriate > > > > PAGE sizes. > > > > > > If the global registers and the runtime registers are so independent > > > that they have to be on different page boundaries, it would make more > > > sense for them to be defined as separate reg regions in the device > > > tree at the very beginning. Then we would only need to change the > > > device tree now and it would be future proof for any page size. > > > > That's great if you have a time machine. Otherwise, NACK. > > I didn't suggest that we need to change it now. But we might need to > be more careful in the future when creating bindings for new hardware. At the time the binding was created there was no reason to believe that the layout would change. -Scott