All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL v2 37/45] pc: Eliminate PcGuestInfo struct
Date: Sat, 6 Feb 2016 21:14:36 +0200	[thread overview]
Message-ID: <1454784308-21177-38-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1454784308-21177-1-git-send-email-mst@redhat.com>

From: Eduardo Habkost <ehabkost@redhat.com>

The struct is not used for anything, now.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/i386/pc.h | 7 +------
 hw/i386/pc.c         | 4 +---
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 0cf67ed..8b3546e 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -33,10 +33,6 @@
 #define kvm_ioapic_in_kernel()   0
 #endif
 
-/* Machine info for ACPI build: */
-struct PcGuestInfo {
-};
-
 /**
  * PCMachineState:
  * @acpi_dev: link to ACPI PM device that performs ACPI hotplug handling
@@ -49,7 +45,6 @@ struct PCMachineState {
 
     /* State for other subsystems/APIs: */
     MemoryHotplugState hotplug_memory;
-    PcGuestInfo acpi_guest_info;
     Notifier machine_done;
 
     /* Pointers to devices and objects: */
@@ -233,7 +228,7 @@ void pc_cpus_init(PCMachineState *pcms);
 void pc_hot_add_cpu(const int64_t id, Error **errp);
 void pc_acpi_init(const char *default_dsdt);
 
-PcGuestInfo *pc_guest_info_init(PCMachineState *pcms);
+void pc_guest_info_init(PCMachineState *pcms);
 
 #define PCI_HOST_PROP_PCI_HOLE_START   "pci-hole-start"
 #define PCI_HOST_PROP_PCI_HOLE_END     "pci-hole-end"
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 66f7bb9..ce185bb 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1183,9 +1183,8 @@ void pc_machine_done(Notifier *notifier, void *data)
     acpi_setup();
 }
 
-PcGuestInfo *pc_guest_info_init(PCMachineState *pcms)
+void pc_guest_info_init(PCMachineState *pcms)
 {
-    PcGuestInfo *guest_info = &pcms->acpi_guest_info;
     int i, j;
 
     pcms->apic_id_limit = pc_apic_id_limit(max_cpus);
@@ -1213,7 +1212,6 @@ PcGuestInfo *pc_guest_info_init(PCMachineState *pcms)
 
     pcms->machine_done.notify = pc_machine_done;
     qemu_add_machine_init_done_notifier(&pcms->machine_done);
-    return guest_info;
 }
 
 /* setup pci memory address space mapping into system address space */
-- 
MST

  parent reply	other threads:[~2016-02-06 19:14 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-06 19:12 [Qemu-devel] [PULL v2 00/45] pc and misc cleanups and fixes, virtio optimizations Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 01/45] Fix virtio migration Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 02/45] pc: acpi: merge SSDT into DSDT Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 03/45] tests: pc: acpi: drop not needed 'expected SSDT' blobs Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 04/45] tests: pc: acpi: add expected DSDT.bridge blobs and update DSDT blobs Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 05/45] virtio: move VirtQueueElement at the beginning of the structs Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 06/45] virtio: move allocation to virtqueue_pop/vring_pop Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 07/45] virtio: introduce qemu_get/put_virtqueue_element Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 08/45] virtio: introduce virtqueue_alloc_element Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 09/45] virtio: slim down allocation of VirtQueueElements Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 10/45] vring: " Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 11/45] virtio: combine the read of a descriptor Michael S. Tsirkin
2016-02-06 19:12 ` [Qemu-devel] [PULL v2 12/45] virtio: cache used_idx in a VirtQueue field Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 13/45] virtio: read avail_idx from VQ only when necessary Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 14/45] virtio: combine write of an entry into used ring Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 15/45] hw/pxb: add pxb devices to the bridge category Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 16/45] vhost-user-test: use correct ROM to speed up and avoid spurious failures Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 17/45] hw/pci: ensure that only PCI/PCIe bridges can be attached to pxb/pxb-pcie devices Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 18/45] ipmi: replace goto by a return statement Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 19/45] ipmi: replace *_MAXCMD defines Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 20/45] ipmi: cleanup error_report messages Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 21/45] ipmi: fix SDR length value Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 22/45] ipmi: introduce a struct ipmi_sdr_compact Michael S. Tsirkin
2016-02-16  7:45   ` Paolo Bonzini
2016-02-16  8:11     ` Cédric Le Goater
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 23/45] ipmi: add get and set SENSOR_TYPE commands Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 24/45] ipmi: add GET_SYS_RESTART_CAUSE chassis command Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 25/45] ipmi: add ACPI power and GUID commands Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 26/45] pc: Move PcGuestInfo declaration to top of file Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 27/45] pc: Eliminate struct PcGuestInfoState Michael S. Tsirkin
2016-02-06 19:13 ` [Qemu-devel] [PULL v2 28/45] pc: Simplify pc_memory_init() signature Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 29/45] pc: Simplify xen_load_linux() signature Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 30/45] acpi: Remove guest_info parameters from functions Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 31/45] acpi: Don't save PcGuestInfo on AcpiBuildState Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 32/45] pc: Remove compat fields from PcGuestInfo Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 33/45] pc: Remove RAM size " Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 34/45] pc: Remove PcGuestInfo.isapc_ram_fw field Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 35/45] pc: Move PcGuestInfo.fw_cfg to PCMachineState Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 36/45] pc: Move APIC and NUMA data from PcGuestInfo " Michael S. Tsirkin
2016-02-06 19:14 ` Michael S. Tsirkin [this message]
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 38/45] acpi: take oem_id in build_header(), optionally Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 39/45] acpi: expose oem_id and oem_table_id in build_rsdt() Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 40/45] acpi: add function to extract oem_id and oem_table_id from the user's SLIC Michael S. Tsirkin
2016-02-06 19:14 ` [Qemu-devel] [PULL v2 41/45] pc: set the OEM fields in the RSDT and the FADT from the SLIC Michael S. Tsirkin
2016-02-06 19:15 ` [Qemu-devel] [PULL v2 42/45] dimm: Correct type of MemoryHotplugState->base Michael S. Tsirkin
2016-02-06 19:15 ` [Qemu-devel] [PULL v2 43/45] intel_iommu: large page support Michael S. Tsirkin
2016-02-06 19:15 ` [Qemu-devel] [PULL v2 44/45] fix MSI injection on Xen Michael S. Tsirkin
2016-02-06 19:15   ` Michael S. Tsirkin
2016-02-12 21:55   ` [Qemu-devel] " Daniel P. Berrange
2016-02-12 21:55     ` Daniel P. Berrange
2016-02-06 19:15 ` [Qemu-devel] [PULL v2 45/45] net: set endianness on all backend devices Michael S. Tsirkin
2016-02-08 12:32 ` [Qemu-devel] [PULL v2 00/45] pc and misc cleanups and fixes, virtio optimizations Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454784308-21177-38-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.