All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 32/32] qemu-char, io: fix ordering of arguments for UDP socket creation
Date: Tue,  9 Feb 2016 13:13:51 +0100	[thread overview]
Message-ID: <1455020031-8268-7-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1455020031-8268-1-git-send-email-pbonzini@redhat.com>

Two wrongs make a right, but they should be fixed anyway.

Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <1455015557-15106-1-git-send-email-pbonzini@redhat.com>
---
 io/channel-socket.c | 2 +-
 qemu-char.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/io/channel-socket.c b/io/channel-socket.c
index 22d2fd6..bf66a78 100644
--- a/io/channel-socket.c
+++ b/io/channel-socket.c
@@ -258,7 +258,7 @@ int qio_channel_socket_dgram_sync(QIOChannelSocket *ioc,
     int fd;
 
     trace_qio_channel_socket_dgram_sync(ioc, localAddr, remoteAddr);
-    fd = socket_dgram(localAddr, remoteAddr, errp);
+    fd = socket_dgram(remoteAddr, localAddr, errp);
     if (fd < 0) {
         trace_qio_channel_socket_dgram_fail(ioc);
         return -1;
diff --git a/qemu-char.c b/qemu-char.c
index 84eb8a1..2b2c56b 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -4386,7 +4386,7 @@ static CharDriverState *qmp_chardev_open_udp(const char *id,
     QIOChannelSocket *sioc = qio_channel_socket_new();
 
     if (qio_channel_socket_dgram_sync(sioc,
-                                      udp->remote, udp->local,
+                                      udp->local, udp->remote,
                                       errp) < 0) {
         object_unref(OBJECT(sioc));
         return NULL;
-- 
2.5.0

  parent reply	other threads:[~2016-02-09 12:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 12:13 [Qemu-devel] [PULL v2 00/32] Misc changes for 2016-02-08 Paolo Bonzini
2016-02-09 12:13 ` [Qemu-devel] [PULL 02/32] memory: RCU ram_list.dirty_memory[] for safe RAM hotplug Paolo Bonzini
2016-02-10 16:56   ` Leon Alrae
2016-02-10 17:01     ` Paolo Bonzini
2016-02-09 12:13 ` [Qemu-devel] [PULL 08/32] hw: Add support for LSI SAS1068 (mptsas) device Paolo Bonzini
2016-02-09 12:13 ` [Qemu-devel] [PULL 29/32] docs/memory.txt: Improve list of different memory regions Paolo Bonzini
2016-02-09 12:13 ` [Qemu-devel] [PULL 30/32] target-i386: fix PSE36 mode Paolo Bonzini
2016-02-09 12:13 ` [Qemu-devel] [PULL 31/32] MAINTAINERS: add all-match entry for qemu-devel@ Paolo Bonzini
2016-02-09 13:47   ` Markus Armbruster
2016-02-09 15:01     ` Paolo Bonzini
2016-02-09 15:24       ` Markus Armbruster
2016-02-09 15:27         ` Peter Maydell
2016-02-09 12:13 ` Paolo Bonzini [this message]
2016-02-09 14:20 ` [Qemu-devel] [PULL v2 00/32] Misc changes for 2016-02-08 Peter Maydell
2016-02-09 14:41   ` Paolo Bonzini
2016-02-09 17:01     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455020031-8268-7-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.