[PATCH 1/2] clk: lpc32xx: add clock frequency output configuration

[PATCH 1/2] clk: lpc32xx: add clock frequency output configuration

[slemieux.tyco]

From: Sylvain Lemieux <slemieux@tycoint.com>

This patch add the support to setup the clock frequency output
using an optional parameter from the device tree.

The previous kernel version did not change the clock frequency
output setup by the kickstart and/or bootloader;
this version always setup the clock frequency output to 208MHz.

Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
---
 drivers/clk/nxp/clk-lpc32xx.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
index 981ff0d..3ab4481 100644
--- a/drivers/clk/nxp/clk-lpc32xx.c
+++ b/drivers/clk/nxp/clk-lpc32xx.c
@@ -1525,9 +1525,12 @@ static void __init lpc32xx_clk_init(struct device_node *np)
 	}
 
 	of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data);
+	if (of_property_read_u32(np, "xtal,clock-output-frequency", &i))
+		/* use default value (208MHz) */
+		i = 208000000;
 
 	/* For 13MHz osc valid output range of PLL is from 156MHz to 266.5MHz */
-	clk_set_rate(clk[LPC32XX_CLK_HCLK_PLL], 208000000);
+	clk_set_rate(clk[LPC32XX_CLK_HCLK_PLL], i);
 
 	/* Set 48MHz rate of USB PLL clock */
 	clk_set_rate(clk[LPC32XX_CLK_USB_PLL], 48000000);
-- 
1.8.3.1

Re: [PATCH 1/2] clk: lpc32xx: add clock frequency output configuration

[Stephen Boyd]

On 02/09, slemieux.tyco@gmail.com wrote:
> From: Sylvain Lemieux <slemieux@tycoint.com>
> 
> This patch add the support to setup the clock frequency output
> using an optional parameter from the device tree.
> 
> The previous kernel version did not change the clock frequency
> output setup by the kickstart and/or bootloader;
> this version always setup the clock frequency output to 208MHz.
> 
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> ---

We have assigned-clock-rates, can you use that instead?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 1/2] clk: lpc32xx: add clock frequency output configuration

[Sylvain Lemieux]

On Tue, 2016-02-09 at 10:57 -0800, Stephen Boyd wrote:
> On 02/09, slemieux.tyco@gmail.com wrote:
> > From: Sylvain Lemieux <slemieux@tycoint.com>
> > 
> > This patch add the support to setup the clock frequency output
> > using an optional parameter from the device tree.
> > 
> > The previous kernel version did not change the clock frequency
> > output setup by the kickstart and/or bootloader;
> > this version always setup the clock frequency output to 208MHz.
> > 
> > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> > ---
> 
> We have assigned-clock-rates, can you use that instead?
> 
I will submit a version 2 with this change tomorrow.

Re: [PATCH 1/2] clk: lpc32xx: add clock frequency output configuration

[Sylvain Lemieux]

On Tue, 2016-02-09 at 10:57 -0800, Stephen Boyd wrote:
> On 02/09, slemieux.tyco@gmail.com wrote:
> > From: Sylvain Lemieux <slemieux@tycoint.com>
> > 
> > This patch add the support to setup the clock frequency output
> > using an optional parameter from the device tree.
> > 
> > The previous kernel version did not change the clock frequency
> > output setup by the kickstart and/or bootloader;
> > this version always setup the clock frequency output to 208MHz.
> > 
> > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> > ---
> 
> We have assigned-clock-rates, can you use that instead?
> 
I will submit a version 2 with this change tomorrow.

Re: [PATCH 1/2] clk: lpc32xx: add clock frequency output configuration

[Sylvain Lemieux]

On Tue, 2016-02-09 at 10:57 -0800, Stephen Boyd wrote:
> On 02/09, slemieux.tyco@gmail.com wrote:
> > From: Sylvain Lemieux <slemieux@tycoint.com>
> > 
> > This patch add the support to setup the clock frequency output
> > using an optional parameter from the device tree.
> > 
> > The previous kernel version did not change the clock frequency
> > output setup by the kickstart and/or bootloader;
> > this version always setup the clock frequency output to 208MHz.
> > 
> > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> > ---
> 
> We have assigned-clock-rates, can you use that instead?
> 
OK, I will submit a new version of the patch tomorrow.

Re: [PATCH 1/2] clk: lpc32xx: add clock frequency output configuration

[Sylvain Lemieux]

On Tue, 2016-02-09 at 10:57 -0800, Stephen Boyd wrote:
> On 02/09, slemieux.tyco@gmail.com wrote:
> > From: Sylvain Lemieux <slemieux@tycoint.com>
> > 
> > This patch add the support to setup the clock frequency output
> > using an optional parameter from the device tree.
> > 
> > The previous kernel version did not change the clock frequency
> > output setup by the kickstart and/or bootloader;
> > this version always setup the clock frequency output to 208MHz.
> > 
> > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> > ---
> 
> We have assigned-clock-rates, can you use that instead?
> 
OK, I will submit a new version of the patch tomorrow.

Re: [PATCH 1/2] clk: lpc32xx: add clock frequency output configuration

[Vladimir Zapolskiy]

Hi Sylvain,

On 09.02.2016 22:07, Sylvain Lemieux wrote:
> On Tue, 2016-02-09 at 10:57 -0800, Stephen Boyd wrote:
>> On 02/09, slemieux.tyco@gmail.com wrote:
>>> From: Sylvain Lemieux <slemieux@tycoint.com>
>>>
>>> This patch add the support to setup the clock frequency output
>>> using an optional parameter from the device tree.
>>>
>>> The previous kernel version did not change the clock frequency
>>> output setup by the kickstart and/or bootloader;
>>> this version always setup the clock frequency output to 208MHz.

ok, it makes perfect sense, and here I see two options, one is to recover
the previous behaviour by removing clk_set_rate() of LPC32XX_CLK_HCLK_PLL
completely, another one (and more preferable) is to add this clock
to a list in include/dt-bindings/clock/lpc32xx-clock.h and set its
rate in a board specific DTB file.

>>> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
>>> ---
>>
>> We have assigned-clock-rates, can you use that instead?
>>
> OK, I will submit a new version of the patch tomorrow.
> 

By the way if you have a cover letter or 2/2 patch in the series,
please send it to linux-clk as well.

--
With best wishes,
Vladimir

Re: [PATCH 1/2] clk: lpc32xx: add clock frequency output configuration

[Sylvain Lemieux]

Hi Vladimir

On Wed, 2016-02-10 at 02:00 +0200, Vladimir Zapolskiy wrote:
> Hi Sylvain,
> 
> On 09.02.2016 22:07, Sylvain Lemieux wrote:
> > On Tue, 2016-02-09 at 10:57 -0800, Stephen Boyd wrote:
> >> On 02/09, slemieux.tyco@gmail.com wrote:
> >>> From: Sylvain Lemieux <slemieux@tycoint.com>
> >>>
> >>> This patch add the support to setup the clock frequency output
> >>> using an optional parameter from the device tree.
> >>>
> >>> The previous kernel version did not change the clock frequency
> >>> output setup by the kickstart and/or bootloader;
> >>> this version always setup the clock frequency output to 208MHz.
> 
> ok, it makes perfect sense, and here I see two options, one is to recover
> the previous behaviour by removing clk_set_rate() of LPC32XX_CLK_HCLK_PLL
> completely, another one (and more preferable) is to add this clock
> to a list in include/dt-bindings/clock/lpc32xx-clock.h and set its
> rate in a board specific DTB file.

I will submit a version 2 of this patch later today using the
second option.

> 
> >>> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> >>> ---
> >>
> >> We have assigned-clock-rates, can you use that instead?
> >>
> > OK, I will submit a new version of the patch tomorrow.
> > 
> 
> By the way if you have a cover letter or 2/2 patch in the series,
> please send it to linux-clk as well.

The was no cover letter for this series (trivial change).

The patch 2/2 was submitted to the "linux-clk" mailling list
(http://thread.gmane.org/gmane.linux.kernel.clk/3911).

> 
> --
> With best wishes,
> Vladimir

Sylvain Lemieux