From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751958AbcBJOSS (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Feb 2016 09:18:18 -0500
Received: from mx2.suse.de ([195.135.220.15]:41252 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751908AbcBJOSQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Feb 2016 09:18:16 -0500
Message-ID: <1455113742.8878.14.camel@suse.com>
Subject: Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software
 Interface
From: Oliver Neukum <oneukum@suse.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Felipe Balbi <balbi@kernel.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        USB <linux-usb@vger.kernel.org>
Date: Wed, 10 Feb 2016 15:15:42 +0100
In-Reply-To: <CAHp75VeUt_uRgxQDxzMw3uoqaRC3TDEyVt1xDSGUicACf4H-_A@mail.gmail.com>
References: <1455037283-106479-1-git-send-email-heikki.krogerus@linux.intel.com>
	 <1455037283-106479-3-git-send-email-heikki.krogerus@linux.intel.com>
	 <CAHp75VeUt_uRgxQDxzMw3uoqaRC3TDEyVt1xDSGUicACf4H-_A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote:
> > +err:
> > +       if (i > 0)
> > +               for (; i >= 0; i--, con--)
> > +                       typec_unregister_port(con->port);
> 
> Perhaps
> 
> while (--i >= 0) {
>  ...
> }

While we are at it. No we should not change the semantics
of conditionals for the sake of appearance.

	Oliver