From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC67C48BE5 for ; Mon, 21 Jun 2021 06:47:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BC8561042 for ; Mon, 21 Jun 2021 06:47:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbhFUGtN (ORCPT ); Mon, 21 Jun 2021 02:49:13 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36352 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbhFUGtM (ORCPT ); Mon, 21 Jun 2021 02:49:12 -0400 Received: from mail-ed1-f71.google.com ([209.85.208.71]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lvDhx-0004mZ-Qg for linux-tegra@vger.kernel.org; Mon, 21 Jun 2021 06:46:57 +0000 Received: by mail-ed1-f71.google.com with SMTP id p19-20020aa7c4d30000b0290394bdda6d9cso328250edr.21 for ; Sun, 20 Jun 2021 23:46:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HBV8dNLDqIEAfk7W6R3y2yg9WhGkmywydr9E1vv22xo=; b=pVe8/c28IrLExRz7KylqHPoFWKQDVpINf0fSPX99jvSV9iW4XmmxoVDzP43xTWNaZc GlZ0EhicE7GYlaVc0b099SDemQ1DcqvVeVguOQkcTM3kEKjGVSzhpDOiU6bGHt/qurY5 MT/agJ1DEI3yJdcygUJe/sEMz17sMiy/feSttEAGC4ZezSCVQwEHYGYCHRGUWdx175Y5 WPk9UksyRgV/261UBjxXjkr5O9/HTPg42FcxDPg2bsS7wQFWDI3oVyOoD0HzYR/4eptK xHqe3Es9mJrpDQKAb2xnCZYoOBssr3n5+4+KS3hSr00xFv2aZ6Vh/R9J1OIK7AAtzl+p rTBQ== X-Gm-Message-State: AOAM5311foh9T9GosozAxQ8E8ZQADL0E1tVSZj+6jaZ3075MbquLHKyL ghjbBTp0WwIspP5RpVgKNj+TVRn/Zyl4rYJzp2rqWrH9lUFfUpNDsTDrw+iZ36WD6C3Z9Lgz7At FF1BYUrDXMkfZl/gH9Ayovxg8qYedWQ28PRKIiG0f X-Received: by 2002:aa7:cb43:: with SMTP id w3mr11978033edt.126.1624258016708; Sun, 20 Jun 2021 23:46:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwW7f8aTJ93Kkruw0X6I/5OojOVeM3oazExumrI1P2lMRb9QkgVXDIlJDsddLfp5/Vdq5FSOA== X-Received: by 2002:aa7:cb43:: with SMTP id w3mr11977987edt.126.1624258016218; Sun, 20 Jun 2021 23:46:56 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id w8sm9950041edc.39.2021.06.20.23.46.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Jun 2021 23:46:55 -0700 (PDT) Subject: Re: [PATCH v3 2/9] dt-bindings: arm-smmu: Add Tegra186 compatible string To: Rob Herring , Thierry Reding , Will Deacon Cc: Joerg Roedel , Linux IOMMU , Jon Hunter , Nicolin Chen , linux-tegra , Robin Murphy , linux-arm-kernel References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-3-thierry.reding@gmail.com> From: Krzysztof Kozlowski Message-ID: <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> Date: Mon, 21 Jun 2021 08:46:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 18/06/2021 21:47, Rob Herring wrote: > On Thu, Jun 3, 2021 at 10:49 AM Thierry Reding wrote: >> >> From: Thierry Reding >> >> The ARM SMMU instantiations found on Tegra186 and later need inter- >> operation with the memory controller in order to correctly program >> stream ID overrides. >> >> Furthermore, on Tegra194 multiple instances of the SMMU can gang up >> to achieve higher throughput. In order to do this, they have to be >> programmed identically so that the memory controller can interleave >> memory accesses between them. >> >> Add the Tegra186 compatible string to make sure the interoperation >> with the memory controller can be enabled on that SoC generation. >> >> Signed-off-by: Thierry Reding >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 9d27aa5111d4..1181b590db71 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -54,8 +54,14 @@ properties: >> - const: arm,mmu-500 >> - description: NVIDIA SoCs that program two ARM MMU-500s identically >> items: >> + - description: NVIDIA SoCs that require memory controller interaction > > This is not valid jsonschema: > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'anyOf' conditional failed, one > must be fixed: > None is not of type 'object', 'boolean' > None is not of type 'array' > from schema $id: http://json-schema.org/draft-07/schema# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > must be fixed: > None is not of type 'object' > None is not of type 'array' > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > must be fixed: > None is not of type 'object' > None is not of type 'array' > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:5:items: 'oneOf' conditional failed, one > must be fixed: > [{'enum': [{'const': 'nvidia,tegra194-smmu'}, {'const': > 'nvidia,tegra186-smmu'}]}, {'const': 'nvidia,smmu-500'}] is not of > type 'object' > {'const': 'nvidia,tegra194-smmu'} is not of type 'string' > {'const': 'nvidia,tegra186-smmu'} is not of type 'string' > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > > This was not reviewed nor tested since the DT list was not Cc'ed. Ugh, I see now weird empty item on a list... and not only DT list was skipped - Thierry did not Cc you either. My bad, I did not check that patch thoroughly before applying. Thierry, please Cc folks mentioned by get_maintainer.pl. Either sent a fix or a revert, if fix needs more time. Additionally, why the patch changes reg to "minItems: 1" for nvidia,tegra194-smmu? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_RED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64404C48BE5 for ; Mon, 21 Jun 2021 06:47:07 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01E686102A for ; Mon, 21 Jun 2021 06:47:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01E686102A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C12F28301F; Mon, 21 Jun 2021 06:47:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nEly3kzF78BF; Mon, 21 Jun 2021 06:47:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9321B82FAE; Mon, 21 Jun 2021 06:47:03 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 603A3C000E; Mon, 21 Jun 2021 06:47:03 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 835C1C000C for ; Mon, 21 Jun 2021 06:47:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5D42C400F3 for ; Mon, 21 Jun 2021 06:47:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U2niCfKrxYUw for ; Mon, 21 Jun 2021 06:47:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by smtp2.osuosl.org (Postfix) with ESMTPS id 0FE24400CD for ; Mon, 21 Jun 2021 06:46:59 +0000 (UTC) Received: from mail-ed1-f70.google.com ([209.85.208.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lvDhx-0004mT-Lg for iommu@lists.linux-foundation.org; Mon, 21 Jun 2021 06:46:57 +0000 Received: by mail-ed1-f70.google.com with SMTP id l9-20020a0564022549b0290394bafbfbcaso435638edb.3 for ; Sun, 20 Jun 2021 23:46:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HBV8dNLDqIEAfk7W6R3y2yg9WhGkmywydr9E1vv22xo=; b=jPkDS4T0ZIRv8bmVNgNm6FU+M+BGLOVPSq3+d+QIN5oLhBh9ix5Tx5ucKe1zr4d4gV 30B03cpaDDzefea/miZCDvL8m//aShKxCRzV9wcZWWQpgRgrlMPJLnuuTycTk+qcVIc1 ch+0+D96mmruTHREZTGIe415Vnqv6nE4Shuup57v92SSwZBKKBf3H9cLFOjAaDT8jnZL iuPfqV5q7Tp757v38FgFbbpQTYg65RR5KxlN2U/84yiHY5yp9kzgMSLMeGk6Mc8fZHe/ 4fEYk1C9vgQG54Gz3xQY44tbGmKHzL1ehqgXhnqqmeZ2tyh5O21noCrtEA1e8qB5sLjO Z4qg== X-Gm-Message-State: AOAM530FV8cCwmI7bATGbcxXUhHMXidVKZtH3XJBcnACjl5D2ghkhVSS TjvkYrCqgI8gWOn/L6HunWxNT63M6CitRf1eqCxL0tKNX4kyhFVfWATPJxaHy9u2TKtGSJEzndc SvcW3lCJYBzlfps/yJApK6RnZT8VvX/p062rELleHW6zLBIY= X-Received: by 2002:aa7:cb43:: with SMTP id w3mr11978035edt.126.1624258016711; Sun, 20 Jun 2021 23:46:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwW7f8aTJ93Kkruw0X6I/5OojOVeM3oazExumrI1P2lMRb9QkgVXDIlJDsddLfp5/Vdq5FSOA== X-Received: by 2002:aa7:cb43:: with SMTP id w3mr11977987edt.126.1624258016218; Sun, 20 Jun 2021 23:46:56 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id w8sm9950041edc.39.2021.06.20.23.46.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Jun 2021 23:46:55 -0700 (PDT) Subject: Re: [PATCH v3 2/9] dt-bindings: arm-smmu: Add Tegra186 compatible string To: Rob Herring , Thierry Reding , Will Deacon References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-3-thierry.reding@gmail.com> From: Krzysztof Kozlowski Message-ID: <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> Date: Mon, 21 Jun 2021 08:46:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: Jon Hunter , Linux IOMMU , Nicolin Chen , linux-tegra , Robin Murphy , linux-arm-kernel X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 18/06/2021 21:47, Rob Herring wrote: > On Thu, Jun 3, 2021 at 10:49 AM Thierry Reding wrote: >> >> From: Thierry Reding >> >> The ARM SMMU instantiations found on Tegra186 and later need inter- >> operation with the memory controller in order to correctly program >> stream ID overrides. >> >> Furthermore, on Tegra194 multiple instances of the SMMU can gang up >> to achieve higher throughput. In order to do this, they have to be >> programmed identically so that the memory controller can interleave >> memory accesses between them. >> >> Add the Tegra186 compatible string to make sure the interoperation >> with the memory controller can be enabled on that SoC generation. >> >> Signed-off-by: Thierry Reding >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 9d27aa5111d4..1181b590db71 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -54,8 +54,14 @@ properties: >> - const: arm,mmu-500 >> - description: NVIDIA SoCs that program two ARM MMU-500s identically >> items: >> + - description: NVIDIA SoCs that require memory controller interaction > > This is not valid jsonschema: > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'anyOf' conditional failed, one > must be fixed: > None is not of type 'object', 'boolean' > None is not of type 'array' > from schema $id: http://json-schema.org/draft-07/schema# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > must be fixed: > None is not of type 'object' > None is not of type 'array' > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > must be fixed: > None is not of type 'object' > None is not of type 'array' > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:5:items: 'oneOf' conditional failed, one > must be fixed: > [{'enum': [{'const': 'nvidia,tegra194-smmu'}, {'const': > 'nvidia,tegra186-smmu'}]}, {'const': 'nvidia,smmu-500'}] is not of > type 'object' > {'const': 'nvidia,tegra194-smmu'} is not of type 'string' > {'const': 'nvidia,tegra186-smmu'} is not of type 'string' > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > > This was not reviewed nor tested since the DT list was not Cc'ed. Ugh, I see now weird empty item on a list... and not only DT list was skipped - Thierry did not Cc you either. My bad, I did not check that patch thoroughly before applying. Thierry, please Cc folks mentioned by get_maintainer.pl. Either sent a fix or a revert, if fix needs more time. Additionally, why the patch changes reg to "minItems: 1" for nvidia,tegra194-smmu? Best regards, Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54003C48BE5 for ; Mon, 21 Jun 2021 06:48:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 153916102A for ; Mon, 21 Jun 2021 06:48:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 153916102A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=o3X94jnzaO+L8xnpOG9+mTbIFwrdYXlZKgI7kAaNei0=; b=4BfAPUv5uP4Z+apozAdagumBIN l3oD7r/VvgGphRva+djwi21E3ajX3IcEXOuwGhPzA6r4TLplAXNelR7zRki/USv/xOhedxCWx14Es 6f5ZdE/X89UYebSrd1+L2PWseuHC3vNgHvBZuTUzVRhO9tSw7LCuXVKCML1fi4Sev279gRV2Z849G abl0UUddrRocP3XMUrNhQGDkC5jubdbtF1uSx5IePikmAFs7rMJ3iElDD3ZaMcCMGBz8VGrZAQE2W 4zTlENGN/JAXklEAeSjQgCxFrLyb0eSVA7YtBc7Zr183aZyi7c32yKf48zzDTY17+qSlXmLC/6pmT +33GIuBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvDi4-002OMr-N7; Mon, 21 Jun 2021 06:47:04 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvDhz-002OK4-U0 for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 06:47:01 +0000 Received: from mail-ed1-f71.google.com ([209.85.208.71]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lvDhy-0004mp-2X for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 06:46:58 +0000 Received: by mail-ed1-f71.google.com with SMTP id p23-20020aa7cc970000b02903948bc39fd5so5179793edt.13 for ; Sun, 20 Jun 2021 23:46:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HBV8dNLDqIEAfk7W6R3y2yg9WhGkmywydr9E1vv22xo=; b=Ltvgu6JMkjhZ9H6Lqa+s4jiiex2PzV0YCLmPuw4gefk23NbpywUHrqf8wySSc8wgwW r14YcuQe2KNsub6yj2d6vLTZQUAFegZYL7rdL8wvqxm3Tj6kCNofP6/PXeiioaB8tyzk 0yX6yvimgNSFnNioLEUhzShRMVJk6jnl8K0MVS6aFhC+RsmYrZGVehCaHjEQl/LEQWTp iLJaxB2hJFPTSY6E51Hpdf0eCw0kRQYH230wPGIn4ns0deaRVgsdF++aQGFA4WeXOLy6 vklERBes4XmbS1PSeuTCifsOwtp16Jf/ufnIn1osqW0yRecVsR8TWPemXdD5XT57uC6a /z0Q== X-Gm-Message-State: AOAM533/6FO0vgXv5YlqBiW72dOTbTY3Sqrew59f3sl75CGtIt3rMHZY eU6H+Yb0CBbIWe+4evLVbjOto+RE/IgxwI9DtSR0vv0fUWZ7crmq4szgUZ8d9BW/IaMPCS9dSWg fh9cuVsgW9xOWZH/i+rAe+2EqT4OzpVOzHmFQcmXolbMxgI7TMCJz X-Received: by 2002:aa7:cb43:: with SMTP id w3mr11978029edt.126.1624258016687; Sun, 20 Jun 2021 23:46:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwW7f8aTJ93Kkruw0X6I/5OojOVeM3oazExumrI1P2lMRb9QkgVXDIlJDsddLfp5/Vdq5FSOA== X-Received: by 2002:aa7:cb43:: with SMTP id w3mr11977987edt.126.1624258016218; Sun, 20 Jun 2021 23:46:56 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id w8sm9950041edc.39.2021.06.20.23.46.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Jun 2021 23:46:55 -0700 (PDT) Subject: Re: [PATCH v3 2/9] dt-bindings: arm-smmu: Add Tegra186 compatible string To: Rob Herring , Thierry Reding , Will Deacon Cc: Joerg Roedel , Linux IOMMU , Jon Hunter , Nicolin Chen , linux-tegra , Robin Murphy , linux-arm-kernel References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-3-thierry.reding@gmail.com> From: Krzysztof Kozlowski Message-ID: <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> Date: Mon, 21 Jun 2021 08:46:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210620_234700_039564_66DA61BF X-CRM114-Status: GOOD ( 21.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/06/2021 21:47, Rob Herring wrote: > On Thu, Jun 3, 2021 at 10:49 AM Thierry Reding wrote: >> >> From: Thierry Reding >> >> The ARM SMMU instantiations found on Tegra186 and later need inter- >> operation with the memory controller in order to correctly program >> stream ID overrides. >> >> Furthermore, on Tegra194 multiple instances of the SMMU can gang up >> to achieve higher throughput. In order to do this, they have to be >> programmed identically so that the memory controller can interleave >> memory accesses between them. >> >> Add the Tegra186 compatible string to make sure the interoperation >> with the memory controller can be enabled on that SoC generation. >> >> Signed-off-by: Thierry Reding >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 9d27aa5111d4..1181b590db71 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -54,8 +54,14 @@ properties: >> - const: arm,mmu-500 >> - description: NVIDIA SoCs that program two ARM MMU-500s identically >> items: >> + - description: NVIDIA SoCs that require memory controller interaction > > This is not valid jsonschema: > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'anyOf' conditional failed, one > must be fixed: > None is not of type 'object', 'boolean' > None is not of type 'array' > from schema $id: http://json-schema.org/draft-07/schema# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > must be fixed: > None is not of type 'object' > None is not of type 'array' > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > must be fixed: > None is not of type 'object' > None is not of type 'array' > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu/arm,smmu.yaml: > properties:compatible:oneOf:5:items: 'oneOf' conditional failed, one > must be fixed: > [{'enum': [{'const': 'nvidia,tegra194-smmu'}, {'const': > 'nvidia,tegra186-smmu'}]}, {'const': 'nvidia,smmu-500'}] is not of > type 'object' > {'const': 'nvidia,tegra194-smmu'} is not of type 'string' > {'const': 'nvidia,tegra186-smmu'} is not of type 'string' > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > > > This was not reviewed nor tested since the DT list was not Cc'ed. Ugh, I see now weird empty item on a list... and not only DT list was skipped - Thierry did not Cc you either. My bad, I did not check that patch thoroughly before applying. Thierry, please Cc folks mentioned by get_maintainer.pl. Either sent a fix or a revert, if fix needs more time. Additionally, why the patch changes reg to "minItems: 1" for nvidia,tegra194-smmu? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel