From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 0/2] DTC unit-address checks
Date: Thu, 11 Feb 2016 14:46:57 -0600 [thread overview]
Message-ID: <1455223619-16052-1-git-send-email-robh@kernel.org> (raw)
I've been much more active in reviewing bindings lately and a few things
are getting old repeating. One is unit-address issues. I happened to be
looking at the old dtc C schema today and found this old patch[1] from
Stephen which never got merged. It derailed into how to updated ePAPR to
clarify for unit-address with ranges property, but didn't seem to have
any other objections. So, I've refreshed Stephen's patch and skip the
check if non-empty ranges is present.
I also added a 2nd patch with checks for leading '0x' or 0s. This should
never be valid. Also, I think Stephen's comment about checking the
address value being difficult is wrong. We should be able to check that
as any bus specific unit addresses should contain commas.
On a build of all dtbs, ARM has 36K warnings! The good news is arm64 is
*only* 400 or so. I've skimmed thru them and they all looked valid to
me.
Any objections to this series will result in getting added as a DT
binding maintainer. :)
Rob
[1] https://lkml.org/lkml/2013/9/19/301
Rob Herring (1):
Warn on node name unit-addresses with '0x' or leading 0s
Stephen Warren (1):
Warn on node name unit-address presence/absence mismatch
checks.c | 38 ++++++++++++++++++++++++++++++++++++--
tests/reg-without-unit-addr.dts | 10 ++++++++++
tests/run_tests.sh | 4 ++++
tests/unit-addr-leading-0s.dts | 10 ++++++++++
tests/unit-addr-leading-0x.dts | 10 ++++++++++
tests/unit-addr-without-reg.dts | 9 +++++++++
6 files changed, 79 insertions(+), 2 deletions(-)
create mode 100644 tests/reg-without-unit-addr.dts
create mode 100644 tests/unit-addr-leading-0s.dts
create mode 100644 tests/unit-addr-leading-0x.dts
create mode 100644 tests/unit-addr-without-reg.dts
--
2.5.0
next reply other threads:[~2016-02-11 20:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 20:46 Rob Herring [this message]
[not found] ` <1455223619-16052-1-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-02-11 20:46 ` [PATCH 1/2] Warn on node name unit-address presence/absence mismatch Rob Herring
[not found] ` <1455223619-16052-2-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-02-19 5:02 ` David Gibson
2016-02-11 20:46 ` [PATCH 2/2] Warn on node name unit-addresses with '0x' or leading 0s Rob Herring
[not found] ` <1455223619-16052-3-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-02-19 5:07 ` David Gibson
[not found] ` <20160219050709.GB15224-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-02-22 16:51 ` Rob Herring
[not found] ` <CAL_JsqLDdyLd4z_Pmsr7+vtnMZsusEpJYZ4tdZmjQFt0PD_Fbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-23 5:47 ` David Gibson
[not found] ` <20160223054746.GT2808-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-02-23 14:35 ` Rob Herring
[not found] ` <CAL_Jsq+Nr6uzA0xzc=zKG4diZwDrgsbLAKDb80m6ZSq2NXcGgA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-24 0:44 ` David Gibson
[not found] ` <20160224004456.GB2808-RXTfZT5YzpxwFLYp8hBm2A@public.gmane.org>
2016-02-24 15:01 ` Rob Herring
2016-02-25 0:49 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455223619-16052-1-git-send-email-robh@kernel.org \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.