From: Scott Wood <oss@buserror.net>
To: Brian Norris <computersforpeace@gmail.com>,
Li Yang <leoli@freescale.com>
Cc: Raghav Dogra <raghav@freescale.com>,
linux-mtd@lists.infradead.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
prabhakar.kushwaha@nxp.com,
Jaiprakash Singh <b44839@freescale.com>
Subject: Re: [PATCH] mtd/ifc: Add support for IFC controller version 2.0
Date: Fri, 12 Feb 2016 14:21:02 -0600 [thread overview]
Message-ID: <1455308462.2463.29.camel@buserror.net> (raw)
In-Reply-To: <20160212194411.GF21465@google.com>
On Fri, 2016-02-12 at 11:44 -0800, Brian Norris wrote:
> On Thu, Feb 04, 2016 at 05:07:16PM -0600, Li Yang wrote:
> > On Wed, Feb 3, 2016 at 12:36 AM, Raghav Dogra <raghav@freescale.com>
> > wrote:
> > > The new IFC controller version 2.0 has a different memory map page.
> > > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
> > > This patch segregates the IFC global and runtime registers to
> > > appropriate
> > > PAGE sizes.
> >
> > If the global registers and the runtime registers are so independent
> > that they have to be on different page boundaries, it would make more
> > sense for them to be defined as separate reg regions in the device
> > tree at the very beginning. Then we would only need to change the
> > device tree now and it would be future proof for any page size.
>
> To be clear: Scott, you were NACK'ing the DT binding change request,
> right? I though we had an Ack on the previous revision (that Raghav
> failed to carry).
Yes. The patch is OK, the DT binding change (which is not in the patch) is
not.
-Scott
next prev parent reply other threads:[~2016-02-12 20:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 6:36 [PATCH] mtd/ifc: Add support for IFC controller version 2.0 Raghav Dogra
2016-02-04 23:07 ` Li Yang
2016-02-05 1:17 ` Scott Wood
2016-02-05 18:05 ` Li Yang
2016-02-05 18:23 ` Scott Wood
2016-02-05 20:08 ` Li Yang
2016-02-12 19:44 ` Brian Norris
2016-02-12 20:21 ` Scott Wood [this message]
2016-02-15 6:18 ` Raghav Dogra
2016-02-15 6:18 ` Raghav Dogra
2016-02-16 0:41 ` Scott Wood
2016-02-16 7:19 ` Raghav Dogra
2016-02-16 7:19 ` Raghav Dogra
2016-02-16 8:36 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455308462.2463.29.camel@buserror.net \
--to=oss@buserror.net \
--cc=b44839@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=leoli@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=prabhakar.kushwaha@nxp.com \
--cc=raghav@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.