From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sun, 14 Feb 2016 18:36:58 -0700 Subject: [U-Boot] [PATCH 14/16] sandbox: spi: Remove an incorrect free() In-Reply-To: <1455500220-1324-1-git-send-email-sjg@chromium.org> References: <1455500220-1324-1-git-send-email-sjg@chromium.org> Message-ID: <1455500220-1324-15-git-send-email-sjg@chromium.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de We must not free data that is managed by driver mode. Remove this line, which is a hangover from the pre-driver-model code. This fixes a problem where 'sf probe' crashes U-Boot if the backing file for the SPI flash cannot be found. Signed-off-by: Simon Glass --- drivers/mtd/spi/sandbox.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/spi/sandbox.c b/drivers/mtd/spi/sandbox.c index ec07be7..53470b9 100644 --- a/drivers/mtd/spi/sandbox.c +++ b/drivers/mtd/spi/sandbox.c @@ -187,7 +187,6 @@ static int sandbox_sf_probe(struct udevice *dev) sbsf->fd = os_open(pdata->filename, 02); if (sbsf->fd == -1) { - free(sbsf); printf("%s: unable to open file '%s'\n", __func__, pdata->filename); ret = -EIO; -- 2.7.0.rc3.207.g0ac5344