From: Phil Blundell <pb@pbcl.net>
To: Ross Burton <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] lib/qa.py: raise ValueError if file isn't an ELF
Date: Mon, 15 Feb 2016 23:30:49 +0000 [thread overview]
Message-ID: <1455579049.2039.22.camel@pbcl.net> (raw)
In-Reply-To: <1455558632-1397-1-git-send-email-ross.burton@intel.com>
On Mon, 2016-02-15 at 17:50 +0000, Ross Burton wrote:
> Instead of raising a generic Exception that can't be handled specifically, raise
> a ValueError.
If what you want is an exception to mean "this file isn't actually ELF",
how about defining a new exception class InvalidElfError or something
and raising that? ValueError still seems a bit vague for what you are
trying to do.
p.
prev parent reply other threads:[~2016-02-15 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 17:50 [PATCH] lib/qa.py: raise ValueError if file isn't an ELF Ross Burton
2016-02-15 23:30 ` Phil Blundell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455579049.2039.22.camel@pbcl.net \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.