From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hongzhou Yang Subject: Re: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration Date: Wed, 24 Feb 2016 12:28:25 -0800 Message-ID: <1456345705.14518.1.camel@mussux00> References: <1456319775-3216-1-git-send-email-ldewangan@nvidia.com> <1456319775-3216-14-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mailgw01.mediatek.com ([66.228.70.111]:54784 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753328AbcBXU2d (ORCPT ); Wed, 24 Feb 2016 15:28:33 -0500 In-Reply-To: <1456319775-3216-14-git-send-email-ldewangan@nvidia.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Laxman Dewangan Cc: linus.walleij@linaro.org, corbet@lwn.net, lee@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org, Matthias Brugger , Yingjoe Chen On Wed, 2016-02-24 at 18:45 +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Matthias Brugger > Cc: Hongzhou Yang > Cc: Yingjoe Chen > --- Acked-by: Hongzhou Yang Thanks, Hongzhou > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > index ddc9217..194413d 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > @@ -1390,17 +1390,16 @@ int mtk_pctrl_init(struct platform_device *pdev, > pctl->pctl_desc.pmxops = &mtk_pmx_ops; > pctl->dev = &pdev->dev; > > - pctl->pctl_dev = pinctrl_register(&pctl->pctl_desc, &pdev->dev, pctl); > + pctl->pctl_dev = devm_pinctrl_register(&pdev->dev, &pctl->pctl_desc, > + pctl); > if (IS_ERR(pctl->pctl_dev)) { > dev_err(&pdev->dev, "couldn't register pinctrl driver\n"); > return PTR_ERR(pctl->pctl_dev); > } > > pctl->chip = devm_kzalloc(&pdev->dev, sizeof(*pctl->chip), GFP_KERNEL); > - if (!pctl->chip) { > - ret = -ENOMEM; > - goto pctrl_error; > - } > + if (!pctl->chip) > + return -ENOMEM; > > *pctl->chip = mtk_gpio_chip; > pctl->chip->ngpio = pctl->devdata->npins; > @@ -1409,10 +1408,8 @@ int mtk_pctrl_init(struct platform_device *pdev, > pctl->chip->base = -1; > > ret = gpiochip_add_data(pctl->chip, pctl); > - if (ret) { > - ret = -EINVAL; > - goto pctrl_error; > - } > + if (ret) > + return -EINVAL; > > /* Register the GPIO to pin mappings. */ > ret = gpiochip_add_pin_range(pctl->chip, dev_name(&pdev->dev), > @@ -1490,8 +1487,6 @@ int mtk_pctrl_init(struct platform_device *pdev, > > chip_error: > gpiochip_remove(pctl->chip); > -pctrl_error: > - pinctrl_unregister(pctl->pctl_dev); > return ret; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758451AbcBXUdg (ORCPT ); Wed, 24 Feb 2016 15:33:36 -0500 Received: from mailgw01.mediatek.com ([69.46.227.141]:56496 "EHLO mailgw01.mediatek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757313AbcBXUdf (ORCPT ); Wed, 24 Feb 2016 15:33:35 -0500 Message-ID: <1456345705.14518.1.camel@mussux00> Subject: Re: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration From: Hongzhou Yang To: Laxman Dewangan CC: , , , , , , , , , , Matthias Brugger , Yingjoe Chen Date: Wed, 24 Feb 2016 12:28:25 -0800 In-Reply-To: <1456319775-3216-14-git-send-email-ldewangan@nvidia.com> References: <1456319775-3216-1-git-send-email-ldewangan@nvidia.com> <1456319775-3216-14-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N X-TM-AS-Product-Ver: SMEX-10.2.0.3308-8.000.1202-22152.000 X-TM-AS-Result: No--8.163700-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-02-24 at 18:45 +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Matthias Brugger > Cc: Hongzhou Yang > Cc: Yingjoe Chen > --- Acked-by: Hongzhou Yang Thanks, Hongzhou > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > index ddc9217..194413d 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > @@ -1390,17 +1390,16 @@ int mtk_pctrl_init(struct platform_device *pdev, > pctl->pctl_desc.pmxops = &mtk_pmx_ops; > pctl->dev = &pdev->dev; > > - pctl->pctl_dev = pinctrl_register(&pctl->pctl_desc, &pdev->dev, pctl); > + pctl->pctl_dev = devm_pinctrl_register(&pdev->dev, &pctl->pctl_desc, > + pctl); > if (IS_ERR(pctl->pctl_dev)) { > dev_err(&pdev->dev, "couldn't register pinctrl driver\n"); > return PTR_ERR(pctl->pctl_dev); > } > > pctl->chip = devm_kzalloc(&pdev->dev, sizeof(*pctl->chip), GFP_KERNEL); > - if (!pctl->chip) { > - ret = -ENOMEM; > - goto pctrl_error; > - } > + if (!pctl->chip) > + return -ENOMEM; > > *pctl->chip = mtk_gpio_chip; > pctl->chip->ngpio = pctl->devdata->npins; > @@ -1409,10 +1408,8 @@ int mtk_pctrl_init(struct platform_device *pdev, > pctl->chip->base = -1; > > ret = gpiochip_add_data(pctl->chip, pctl); > - if (ret) { > - ret = -EINVAL; > - goto pctrl_error; > - } > + if (ret) > + return -EINVAL; > > /* Register the GPIO to pin mappings. */ > ret = gpiochip_add_pin_range(pctl->chip, dev_name(&pdev->dev), > @@ -1490,8 +1487,6 @@ int mtk_pctrl_init(struct platform_device *pdev, > > chip_error: > gpiochip_remove(pctl->chip); > -pctrl_error: > - pinctrl_unregister(pctl->pctl_dev); > return ret; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: hongzhou.yang@mediatek.com (Hongzhou Yang) Date: Wed, 24 Feb 2016 12:28:25 -0800 Subject: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration In-Reply-To: <1456319775-3216-14-git-send-email-ldewangan@nvidia.com> References: <1456319775-3216-1-git-send-email-ldewangan@nvidia.com> <1456319775-3216-14-git-send-email-ldewangan@nvidia.com> Message-ID: <1456345705.14518.1.camel@mussux00> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2016-02-24 at 18:45 +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Matthias Brugger > Cc: Hongzhou Yang > Cc: Yingjoe Chen > --- Acked-by: Hongzhou Yang Thanks, Hongzhou > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > index ddc9217..194413d 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > @@ -1390,17 +1390,16 @@ int mtk_pctrl_init(struct platform_device *pdev, > pctl->pctl_desc.pmxops = &mtk_pmx_ops; > pctl->dev = &pdev->dev; > > - pctl->pctl_dev = pinctrl_register(&pctl->pctl_desc, &pdev->dev, pctl); > + pctl->pctl_dev = devm_pinctrl_register(&pdev->dev, &pctl->pctl_desc, > + pctl); > if (IS_ERR(pctl->pctl_dev)) { > dev_err(&pdev->dev, "couldn't register pinctrl driver\n"); > return PTR_ERR(pctl->pctl_dev); > } > > pctl->chip = devm_kzalloc(&pdev->dev, sizeof(*pctl->chip), GFP_KERNEL); > - if (!pctl->chip) { > - ret = -ENOMEM; > - goto pctrl_error; > - } > + if (!pctl->chip) > + return -ENOMEM; > > *pctl->chip = mtk_gpio_chip; > pctl->chip->ngpio = pctl->devdata->npins; > @@ -1409,10 +1408,8 @@ int mtk_pctrl_init(struct platform_device *pdev, > pctl->chip->base = -1; > > ret = gpiochip_add_data(pctl->chip, pctl); > - if (ret) { > - ret = -EINVAL; > - goto pctrl_error; > - } > + if (ret) > + return -EINVAL; > > /* Register the GPIO to pin mappings. */ > ret = gpiochip_add_pin_range(pctl->chip, dev_name(&pdev->dev), > @@ -1490,8 +1487,6 @@ int mtk_pctrl_init(struct platform_device *pdev, > > chip_error: > gpiochip_remove(pctl->chip); > -pctrl_error: > - pinctrl_unregister(pctl->pctl_dev); > return ret; > } >