All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: qemu-devel@nongnu.org
Cc: prem@barefootnetworks.com, daniel@iogearbox.net,
	stefanha@gmail.com, jasowang@redhat.com,
	parag.bhide@barefootnetworks.com, idosch@mellanox.com,
	sfeldma@gmail.com, eladr@mellanox.com, pbonzini@redhat.com,
	alexei.starovoitov@gmail.com
Subject: [Qemu-devel] [patch qemu v2 2/4] rocker: return -ENOMEM in case of some world alloc fails
Date: Thu, 25 Feb 2016 15:31:56 +0100	[thread overview]
Message-ID: <1456410718-24506-3-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1456410718-24506-1-git-send-email-jiri@resnulli.us>

From: Jiri Pirko <jiri@mellanox.com>

Until now, 0 is returned in this error case. Fix it ro return -ENOMEM.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
v1->v2:
- new patch
---
 hw/net/rocker/rocker.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
index a1d921d..104c097 100644
--- a/hw/net/rocker/rocker.c
+++ b/hw/net/rocker/rocker.c
@@ -1301,6 +1301,7 @@ static int pci_rocker_init(PCIDevice *dev)
 
     for (i = 0; i < ROCKER_WORLD_TYPE_MAX; i++) {
         if (!r->worlds[i]) {
+            err = -ENOMEM;
             goto err_world_alloc;
         }
     }
-- 
2.4.3

  parent reply	other threads:[~2016-02-25 14:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 14:31 [Qemu-devel] [patch qemu v2 0/4] rocker: prepare for easy addition of other worlds Jiri Pirko
2016-02-25 14:31 ` [Qemu-devel] [patch qemu v2 1/4] rocker: forbid to change world type Jiri Pirko
2016-02-25 14:31 ` Jiri Pirko [this message]
2016-02-25 14:31 ` [Qemu-devel] [patch qemu v2 3/4] rocker: add name field into WorldOps ale let world specify its name Jiri Pirko
2016-02-25 14:31 ` [Qemu-devel] [patch qemu v2 4/4] rocker: allow user to specify rocker world by property Jiri Pirko
2016-03-02  2:48 ` [Qemu-devel] [patch qemu v2 0/4] rocker: prepare for easy addition of other worlds Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456410718-24506-3-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=alexei.starovoitov@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=eladr@mellanox.com \
    --cc=idosch@mellanox.com \
    --cc=jasowang@redhat.com \
    --cc=parag.bhide@barefootnetworks.com \
    --cc=pbonzini@redhat.com \
    --cc=prem@barefootnetworks.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sfeldma@gmail.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.