From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/6] ARM: keystone2: psc-defs: use adequate () for macros
Date: Thu, 25 Feb 2016 12:53:43 -0600 [thread overview]
Message-ID: <1456426427-23166-3-git-send-email-nm@ti.com> (raw)
In-Reply-To: <1456426427-23166-1-git-send-email-nm@ti.com>
'#define X a | b' is better defined as '#define X (a | b)' for obvious
reasons.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
V2: No change
V1: https://patchwork.ozlabs.org/patch/510211/
arch/arm/mach-keystone/include/mach/psc_defs.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-keystone/include/mach/psc_defs.h b/arch/arm/mach-keystone/include/mach/psc_defs.h
index 70d22cf21787..2202946be5ea 100644
--- a/arch/arm/mach-keystone/include/mach/psc_defs.h
+++ b/arch/arm/mach-keystone/include/mach/psc_defs.h
@@ -30,9 +30,9 @@
#define BOOTBITMASK(x, y) ((((((u32)1 << (((u32)x) - ((u32)y) + (u32)1)) - \
(u32)1)) << ((u32)y)))
-#define BOOT_READ_BITFIELD(z, x, y) (((u32)z) & BOOTBITMASK(x, y)) >> (y)
-#define BOOT_SET_BITFIELD(z, f, x, y) (((u32)z) & ~BOOTBITMASK(x, y)) | \
- ((((u32)f) << (y)) & BOOTBITMASK(x, y))
+#define BOOT_READ_BITFIELD(z, x, y) ((((u32)z) & BOOTBITMASK(x, y)) >> (y))
+#define BOOT_SET_BITFIELD(z, f, x, y) ((((u32)z) & ~BOOTBITMASK(x, y)) | \
+ ((((u32)f) << (y)) & BOOTBITMASK(x, y)))
/* PDCTL */
#define PSC_REG_PDCTL_SET_NEXT(x, y) BOOT_SET_BITFIELD((x), (y), 0, 0)
--
2.7.0
next prev parent reply other threads:[~2016-02-25 18:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 18:53 [U-Boot] [PATCH V2 0/6] ARM: keystone: K2G: Add support for PMMC remoteproc load Nishanth Menon
2016-02-25 18:53 ` [U-Boot] [PATCH V2 1/6] ARM: keystone2: psc: redo doc in kernel-doc format Nishanth Menon
2016-02-26 18:17 ` Tom Rini
2016-03-15 11:56 ` [U-Boot] [U-Boot, V2, " Tom Rini
2016-02-25 18:53 ` Nishanth Menon [this message]
2016-02-26 18:17 ` [U-Boot] [PATCH V2 2/6] ARM: keystone2: psc-defs: use adequate () for macros Tom Rini
2016-02-27 0:13 ` Nishanth Menon
2016-03-15 11:56 ` [U-Boot] [U-Boot, V2, " Tom Rini
2016-02-25 18:53 ` [U-Boot] [PATCH V2 3/6] ARM: keystone2: psc: introduce function to hold and release module in reset Nishanth Menon
2016-02-26 18:18 ` Tom Rini
2016-03-15 11:56 ` [U-Boot] [U-Boot, V2, " Tom Rini
2016-02-25 18:53 ` [U-Boot] [PATCH V2 4/6] remoteproc: Add support for TI power processor Nishanth Menon
2016-02-26 18:18 ` Tom Rini
2016-03-15 11:56 ` [U-Boot] [U-Boot, V2, " Tom Rini
2016-02-25 18:53 ` [U-Boot] [PATCH V2 5/6] ARM: dts: k2g: Add support for PMMC Nishanth Menon
2016-02-26 18:18 ` Tom Rini
2016-02-27 0:18 ` Nishanth Menon
2016-02-27 0:27 ` Tom Rini
2016-02-27 1:10 ` Nishanth Menon
2016-03-04 22:08 ` Tom Rini
2016-03-04 22:08 ` Tom Rini
2016-03-15 11:56 ` [U-Boot] [U-Boot,V2,5/6] " Tom Rini
2016-02-25 18:53 ` [U-Boot] [PATCH V2 6/6] configs: k2g_evm: Add TI power processor support Nishanth Menon
2016-02-26 18:18 ` Tom Rini
2016-03-15 11:57 ` [U-Boot] [U-Boot, V2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456426427-23166-3-git-send-email-nm@ti.com \
--to=nm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.