From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E0FC3A5A4 for ; Sun, 1 Sep 2019 07:15:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80F8C233A2 for ; Sun, 1 Sep 2019 07:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728837AbfIAHO7 (ORCPT ); Sun, 1 Sep 2019 03:14:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40934 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728758AbfIAHO6 (ORCPT ); Sun, 1 Sep 2019 03:14:58 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB10F189DAD1; Sun, 1 Sep 2019 07:14:58 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-255.rdu2.redhat.com [10.10.120.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 41D0A19C70; Sun, 1 Sep 2019 07:14:57 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190901020519.2392-1-hdanton@sina.com> References: <20190901020519.2392-1-hdanton@sina.com> <20190831135906.6028-1-hdanton@sina.com> To: Hillf Danton Cc: dhowells@redhat.com, netdev@vger.kernel.org, marc.dionne@auristor.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] rxrpc: Fix lack of conn cleanup when local endpoint is cleaned up [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <14575.1567322096.1@warthog.procyon.org.uk> Date: Sun, 01 Sep 2019 08:14:56 +0100 Message-ID: <14576.1567322096@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Sun, 01 Sep 2019 07:14:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hillf Danton wrote: > > It's certainly possible that that can happen. The reaper is per > > network-namespace. > > > > conn->params.local holds a ref on the local endpoint. > > > Then local endpoint can not become dead without connection reaper > running first, because of the ref held by connection. When it is > dead, however, there is no need to run reaper directly (rather than > through a workqueue). The reaper is per-net_ns, not per-local. There may be more than one local endpoint in a net_ns and they share the list of service connections. David