From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965548AbcCOKJX (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Mar 2016 06:09:23 -0400
Received: from smtprelay0123.hostedemail.com ([216.40.44.123]:52210 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S964958AbcCOKJP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Mar 2016 06:09:15 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3870:3871:3874:4321:5007:6261:10004:10400:10848:11026:11232:11658:11914:12517:12519:12740:13069:13161:13229:13311:13357:13439:14659:21080:30003:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none
X-HE-Tag: soda73_4ecce07026d5c
X-Filterd-Recvd-Size: 1656
Message-ID: <1458036540.11972.183.camel@perches.com>
Subject: Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t
From: Joe Perches <joe@perches.com>
To: Arnd Bergmann <arnd@arndb.de>, "David S . Miller" <davem@davemloft.net>
Cc: Marcin Wojtas <mw@semihalf.com>, Evan Wang <xswang@marvell.com>,
        Gregory CLEMENT <gregory.clement@free-electrons.com>,
        netdev@vger.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Nicolas Schichan <nschichan@freebox.fr>, linux-kernel@vger.kernel.org
Date: Tue, 15 Mar 2016 03:09:00 -0700
In-Reply-To: <1458036233-2770406-1-git-send-email-arnd@arndb.de>
References: <1458036233-2770406-1-git-send-email-arnd@arndb.de>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-03-15 at 11:03 +0100, Arnd Bergmann wrote:
> A recent change to the mbus driver added a warning printk that
> prints a phys_addr_t using the %x format string, which fails in
> case we build with 64-bit phys_addr_t:

Hey Arnd.

This is a bad patch subject, %pad is for a dma_addr_t.
The patch subject made me assume the patch was incorrect.

> > This uses the special %pa format string instead, so we always
> print the correct type.
[]
> -	pr_err("invalid dram address 0x%x\n", phyaddr);
> +	pr_err("invalid dram address %pa\n", &phyaddr);

The patch is good though.