From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53138)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1afode-00075o-De
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 09:04:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1afodb-0004nB-Ox
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 09:03:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36740)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1afodb-0004n7-JR
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 09:03:51 -0400
Message-ID: <1458047027.13231.46.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 15 Mar 2016 14:03:47 +0100
In-Reply-To: <20160315113016-mutt-send-email-mst@redhat.com>
References: <1457974531-8768-1-git-send-email-minyard@acm.org>
	<20160315085654-mutt-send-email-mst@redhat.com>
	<1458025488.13231.20.camel@redhat.com>
	<20160315091411-mutt-send-email-mst@redhat.com>
	<1458027249.13231.27.camel@redhat.com>
	<20160315093529-mutt-send-email-mst@redhat.com>
	<1458031522.13231.39.camel@redhat.com>
	<20160315113016-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] Sort the fw_cfg file list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, minyard@acm.org, Corey Minyard <cminyard@mvista.com>

  Hi,

> So here is what I propose instead:
>=20
> - always initialize it late
> - sort late, a machine done, not when inserting entries
> - figure out what the order of existing entries is currently,
>   and fill an array listing them in this order.
>   for old machine types, insert the existing entries
>   in this specific order by using a sorting function:

What is the point of using *two* ways to sort entries?

Sure, we can explicitly write down the current order of fw_cfg entries
and use that to sort them, so order stays as-is even if the
initialization order changes.  But when going that route I would do that
*instead* of the alphabetical ordering, for all machine types.

cheers,
  Gerd