All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	crosthwaitepeter@gmail.com, "open list:ARM" <qemu-arm@nongnu.org>,
	pbonzini@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
	aurelien@aurel32.net, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v9 7/9] target-arm: dfilter support for in_asm
Date: Tue, 15 Mar 2016 14:30:22 +0000	[thread overview]
Message-ID: <1458052224-9316-9-git-send-email-alex.bennee@linaro.org> (raw)
In-Reply-To: <1458052224-9316-1-git-send-email-alex.bennee@linaro.org>

Each individual architecture needs to use the qemu_log_in_addr_range()
feature for enabling in_asm output as it is part of the frontend.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Richard Henderson  <rth@twiddle.net>

---
v5
  - no longer wrapping tcg_gen_insn_start (was tcg_gen_debug)
  - reword to handle only in_asm
  - added r-b tag
v8
  - added r-b tag
---
 target-arm/translate-a64.c | 3 ++-
 target-arm/translate.c     | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index f0c73df..b13cff7 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -11225,7 +11225,8 @@ done_generating:
     gen_tb_end(tb, num_insns);
 
 #ifdef DEBUG_DISAS
-    if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
+    if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) &&
+        qemu_log_in_addr_range(pc_start)) {
         qemu_log("----------------\n");
         qemu_log("IN: %s\n", lookup_symbol(pc_start));
         log_target_disas(cs, pc_start, dc->pc - pc_start,
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 025c7a5..78df0b6 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -11718,7 +11718,8 @@ done_generating:
     gen_tb_end(tb, num_insns);
 
 #ifdef DEBUG_DISAS
-    if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
+    if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) &&
+        qemu_log_in_addr_range(pc_start)) {
         qemu_log("----------------\n");
         qemu_log("IN: %s\n", lookup_symbol(pc_start));
         log_target_disas(cs, pc_start, dc->pc - pc_start,
-- 
2.7.2

  parent reply	other threads:[~2016-03-15 14:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 14:30 [Qemu-devel] [PATCH v9 0/9] qemu-log, -dfilter and other logging tweaks Alex Bennée
2016-03-15 14:30 ` [Qemu-devel] [PATCH v9] cputlb: modernise the debug support Alex Bennée
2016-03-15 14:30 ` [Qemu-devel] [PATCH v9 1/9] tcg: pass down TranslationBlock to tcg_code_gen Alex Bennée
2016-03-15 14:30 ` [Qemu-devel] [PATCH v9 2/9] qemu-log: correct help text for -d cpu Alex Bennée
2016-03-15 14:30 ` [Qemu-devel] [PATCH v9 3/9] qemu-log: Avoid function call for disabled qemu_log_mask logging Alex Bennée
2016-03-15 14:30 ` [Qemu-devel] [PATCH v9 4/9] qemu-log: Improve the "exec" TB execution logging Alex Bennée
2016-03-15 14:30 ` [Qemu-devel] [PATCH v9 5/9] qemu-log: new option -dfilter to limit output Alex Bennée
2016-03-15 14:30 ` [Qemu-devel] [PATCH v9 6/9] qemu-log: dfilter-ise exec, out_asm, op and opt_op Alex Bennée
2016-03-15 14:30 ` Alex Bennée [this message]
2016-03-15 14:30 ` [Qemu-devel] [PATCH v9 8/9] qemu-log: support simple pid substitution for logs Alex Bennée
2016-03-15 14:30 ` [Qemu-devel] [PATCH v9 9/9] cputlb: modernise the debug support Alex Bennée
2016-03-15 15:04 ` [Qemu-devel] [PATCH v9 0/9] qemu-log, -dfilter and other logging tweaks Richard Henderson
2016-03-15 16:05   ` Alex Bennée
2016-03-15 17:40     ` Richard Henderson
2016-03-15 18:09       ` Alex Bennée
2016-03-15 18:10         ` Paolo Bonzini
2016-03-16  9:06           ` Alex Bennée
2016-03-16 11:12             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458052224-9316-9-git-send-email-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=crosthwaitepeter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.