From: Johannes Berg <johannes@sipsolutions.net>
To: Roger James <roger@beardandsandals.co.uk>,
linux-wireless@vger.kernel.org
Subject: Re: The mac80211 softmac driver subsystem and handling of monitor interfaces
Date: Wed, 16 Mar 2016 10:56:57 +0100 [thread overview]
Message-ID: <1458122217.2158.4.camel@sipsolutions.net> (raw)
In-Reply-To: <56E92D0A.9090905@beardandsandals.co.uk> (sfid-20160316_105322_529591_4414BB8B)
On Wed, 2016-03-16 at 09:53 +0000, Roger James wrote:
>
> However that only accounts for the ath10k, iwldvm, and iwlmvm
> drivers. I realise that there is a lot of history here, but is what
> the remaining drivers doing in any way deprecated? Also can anyone
> give me a heads up on what the architectural difference is between
> hooking the monitor config change and and setting the want monitor
> flag. Is one way preferable to the other? Both seem to inform the
> driver that there is a transition between having no monitor virtual
> interfaces and having one or more.
Not quite. CONF_MONITOR says "you have >0" monitor interfaces.
drv_add_interface(type=monitor) says "you have >0 monitor interfaces
and 0 others", so there's a difference.
Checking type==monitor in add_interface() *without*
setting WANT_MONITOR_VIF will never be true, since that cannot happen.
Not sure which drivers are doing that, and why they'd try to.
johannes
next prev parent reply other threads:[~2016-03-16 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 9:53 The mac80211 softmac driver subsystem and handling of monitor interfaces Roger James
2016-03-16 9:56 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-15 10:42 Roger James
2016-03-15 12:15 ` Johannes Berg
2016-03-15 13:01 ` Roger James
2016-03-15 13:08 ` Johannes Berg
2016-03-15 16:42 ` Roger James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458122217.2158.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=roger@beardandsandals.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.