From: MaJun <majun258@huawei.com> To: <Catalin.Marinas@arm.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <Will.Deacon@arm.com>, <mark.rutland@arm.com>, <marc.zyngier@arm.com>, <jason@lakedaemon.net>, <tglx@linutronix.de>, <lizefan@huawei.com>, <huxinwei@huawei.com>, <dingtianhong@huawei.com>, <liguozhu@hisilicon.com>, <guohanjun@huawei.com>, <majun258@huawei.com>, <zhaojunhua@hisilicon.com> Subject: [PATCH v3 2/2] irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition. Date: Thu, 17 Mar 2016 16:34:01 +0800 [thread overview] Message-ID: <1458203641-17172-3-git-send-email-majun258@huawei.com> (raw) In-Reply-To: <1458203641-17172-1-git-send-email-majun258@huawei.com> From: Ma Jun <majun258@huawei.com> In current mbigen driver, each mbigen device is initialized as a platform device. When these devices belong to same mbigen hardware module(chip), they use the same register definition in their device node and caused the problem of registers remapped repeatedly. Now, I try to initialize the mbigen module(chip) as a platform device and remap the register once to fix this problem. Signed-off-by: Ma Jun <majun258@huawei.com> --- drivers/irqchip/irq-mbigen.c | 30 +++++++++++++++++++++--------- 1 files changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index 4dd3eb8..4d413bc 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -242,6 +242,8 @@ static int mbigen_device_probe(struct platform_device *pdev) struct resource *res; struct irq_domain *domain; u32 num_pins; + struct platform_device *child_pdev; + struct device_node *np; mgn_chip = devm_kzalloc(&pdev->dev, sizeof(*mgn_chip), GFP_KERNEL); if (!mgn_chip) @@ -251,25 +253,35 @@ static int mbigen_device_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); mgn_chip->base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(mgn_chip->base)) return PTR_ERR(mgn_chip->base); - if (of_property_read_u32(pdev->dev.of_node, "num-pins", &num_pins) < 0) { - dev_err(&pdev->dev, "No num-pins property\n"); - return -EINVAL; - } + for_each_child_of_node(pdev->dev.of_node, np) { + if (!of_property_read_bool(np, "interrupt-controller")) + continue; + + child_pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); + if (IS_ERR(child_pdev)) + return PTR_ERR(child_pdev); + + if (of_property_read_u32(child_pdev->dev.of_node, "num-pins", &num_pins) < 0) { + dev_err(&pdev->dev, "No num-pins property\n"); + return -EINVAL; + } - domain = platform_msi_create_device_domain(&pdev->dev, num_pins, + domain = platform_msi_create_device_domain(&child_pdev->dev, num_pins, mbigen_write_msg, &mbigen_domain_ops, mgn_chip); - if (!domain) - return -ENOMEM; + if (!domain) + return -ENOMEM; - platform_set_drvdata(pdev, mgn_chip); + dev_info(&child_pdev->dev, "Allocated %d MSIs\n", num_pins); + } - dev_info(&pdev->dev, "Allocated %d MSIs\n", num_pins); + platform_set_drvdata(pdev, mgn_chip); return 0; } -- 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: majun258@huawei.com (MaJun) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/2] irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition. Date: Thu, 17 Mar 2016 16:34:01 +0800 [thread overview] Message-ID: <1458203641-17172-3-git-send-email-majun258@huawei.com> (raw) In-Reply-To: <1458203641-17172-1-git-send-email-majun258@huawei.com> From: Ma Jun <majun258@huawei.com> In current mbigen driver, each mbigen device is initialized as a platform device. When these devices belong to same mbigen hardware module(chip), they use the same register definition in their device node and caused the problem of registers remapped repeatedly. Now, I try to initialize the mbigen module(chip) as a platform device and remap the register once to fix this problem. Signed-off-by: Ma Jun <majun258@huawei.com> --- drivers/irqchip/irq-mbigen.c | 30 +++++++++++++++++++++--------- 1 files changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index 4dd3eb8..4d413bc 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -242,6 +242,8 @@ static int mbigen_device_probe(struct platform_device *pdev) struct resource *res; struct irq_domain *domain; u32 num_pins; + struct platform_device *child_pdev; + struct device_node *np; mgn_chip = devm_kzalloc(&pdev->dev, sizeof(*mgn_chip), GFP_KERNEL); if (!mgn_chip) @@ -251,25 +253,35 @@ static int mbigen_device_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); mgn_chip->base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(mgn_chip->base)) return PTR_ERR(mgn_chip->base); - if (of_property_read_u32(pdev->dev.of_node, "num-pins", &num_pins) < 0) { - dev_err(&pdev->dev, "No num-pins property\n"); - return -EINVAL; - } + for_each_child_of_node(pdev->dev.of_node, np) { + if (!of_property_read_bool(np, "interrupt-controller")) + continue; + + child_pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); + if (IS_ERR(child_pdev)) + return PTR_ERR(child_pdev); + + if (of_property_read_u32(child_pdev->dev.of_node, "num-pins", &num_pins) < 0) { + dev_err(&pdev->dev, "No num-pins property\n"); + return -EINVAL; + } - domain = platform_msi_create_device_domain(&pdev->dev, num_pins, + domain = platform_msi_create_device_domain(&child_pdev->dev, num_pins, mbigen_write_msg, &mbigen_domain_ops, mgn_chip); - if (!domain) - return -ENOMEM; + if (!domain) + return -ENOMEM; - platform_set_drvdata(pdev, mgn_chip); + dev_info(&child_pdev->dev, "Allocated %d MSIs\n", num_pins); + } - dev_info(&pdev->dev, "Allocated %d MSIs\n", num_pins); + platform_set_drvdata(pdev, mgn_chip); return 0; } -- 1.7.1
next prev parent reply other threads:[~2016-03-17 8:34 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-17 8:33 [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen driver MaJun 2016-03-17 8:33 ` MaJun 2016-03-17 8:34 ` [PATCH v3 1/2] irqchip/mbigen:Change the mbigen node definition in dt binding file MaJun 2016-03-17 8:34 ` MaJun 2016-03-21 10:30 ` [tip:irq/urgent] irqchip/mbigen: Adjust DT bindings to handle multiple devices in a module tip-bot for MaJun 2016-03-17 8:34 ` MaJun [this message] 2016-03-17 8:34 ` [PATCH v3 2/2] irqchip/mbigen:Change the mbigen driver based on the new mbigen node definition MaJun 2016-03-21 10:30 ` [tip:irq/urgent] irqchip/mbigen: Handle multiple device nodes in a mbigen module tip-bot for MaJun 2016-03-21 10:29 ` [PATCH v3 0/2] irqchip/mbigen: fix the IO remap problem in mbigen driver Thomas Gleixner 2016-03-21 10:29 ` Thomas Gleixner 2016-03-22 3:10 ` majun (F) 2016-03-22 3:10 ` majun (F) 2016-05-05 14:49 ` Marc Zyngier 2016-05-05 14:49 ` Marc Zyngier 2016-05-06 1:12 ` majun (F) 2016-05-06 1:12 ` majun (F) 2016-05-06 7:32 ` Marc Zyngier 2016-05-06 7:32 ` Marc Zyngier 2016-05-06 9:07 ` majun (F) 2016-05-06 9:07 ` majun (F) -- strict thread matches above, loose matches on Subject: below -- 2016-02-01 11:44 [RFC PATCH] irq/mbigen:Fix the problem of IO remap for duplicated physical address " MaJun 2016-02-01 11:57 ` Mark Rutland 2016-02-01 13:06 ` majun (F) 2016-02-01 13:25 ` Mark Rutland 2016-02-02 10:25 ` majun (F) 2016-02-02 11:43 ` Mark Rutland 2016-02-03 2:31 ` majun (F) 2016-02-03 11:16 ` Mark Rutland 2016-02-16 7:54 ` majun (F)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1458203641-17172-3-git-send-email-majun258@huawei.com \ --to=majun258@huawei.com \ --cc=Catalin.Marinas@arm.com \ --cc=Will.Deacon@arm.com \ --cc=dingtianhong@huawei.com \ --cc=guohanjun@huawei.com \ --cc=huxinwei@huawei.com \ --cc=jason@lakedaemon.net \ --cc=liguozhu@hisilicon.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lizefan@huawei.com \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=tglx@linutronix.de \ --cc=zhaojunhua@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.