All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.com>, Petr Mladek <pmladek@suse.com>,
	Tejun Heo <tj@kernel.org>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	linux-kernel@vger.kernel.org,
	Byungchul Park <byungchul.park@lge.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Jan Kara <jack@suse.cz>
Subject: [RFC][PATCH v5 2/2] printk: Make wake_up_klogd_work_func() async
Date: Sun, 20 Mar 2016 23:13:11 +0900	[thread overview]
Message-ID: <1458483191-3596-3-git-send-email-sergey.senozhatsky@gmail.com> (raw)
In-Reply-To: <1458483191-3596-1-git-send-email-sergey.senozhatsky@gmail.com>

From: Jan Kara <jack@suse.cz>

Offload printing of scheduler deferred messages from IRQ context
to a schedulable printing kthread, when possible (the same way we
do it in vprintk_emit()). Otherwise, the CPU can spend unbounded
amount of time doing printing in console_unlock() from IRQ.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
 kernel/printk/printk.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index cf7906e..e8dfe88 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -348,9 +348,16 @@ static void wake_up_klogd_work_func(struct irq_work *irq_work)
 	int pending = __this_cpu_xchg(printk_pending, 0);
 
 	if (pending & PRINTK_PENDING_OUTPUT) {
-		/* If trylock fails, someone else is doing the printing */
-		if (console_trylock())
-			console_unlock();
+		if (!printk_sync && printk_kthread) {
+			wake_up_process(printk_kthread);
+		} else {
+			/*
+			 * If trylock fails, someone else is doing
+			 * the printing
+			 */
+			if (console_trylock())
+				console_unlock();
+		}
 	}
 
 	if (pending & PRINTK_PENDING_WAKEUP)
-- 
2.8.0.rc0

      parent reply	other threads:[~2016-03-20 14:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-20 14:13 [RFC][PATCH v5 0/2] printk: Make printk() completely async Sergey Senozhatsky
2016-03-20 14:13 ` [RFC][PATCH v5 1/2] " Sergey Senozhatsky
2016-03-21  0:06   ` Byungchul Park
2016-03-21  0:43     ` Sergey Senozhatsky
2016-03-21  0:56       ` Byungchul Park
2016-03-21  7:35         ` Sergey Senozhatsky
2016-03-21  8:07           ` Byungchul Park
2016-03-21  8:47             ` Byungchul Park
2016-03-21  9:28               ` Sergey Senozhatsky
2016-03-21 14:32                 ` Jan Kara
2016-03-21 14:58                   ` Sergey Senozhatsky
2016-03-21 15:33                     ` Jan Kara
2016-03-21 17:11                       ` Sergey Senozhatsky
2016-03-22  2:18                         ` Byungchul Park
2016-03-22  2:13                 ` Byungchul Park
2016-03-22  5:52                   ` Sergey Senozhatsky
2016-03-22  6:57                     ` Byungchul Park
2016-03-22  7:43                       ` Sergey Senozhatsky
2016-03-21  8:51             ` Sergey Senozhatsky
2016-03-20 14:13 ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458483191-3596-3-git-send-email-sergey.senozhatsky@gmail.com \
    --to=sergey.senozhatsky@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=byungchul.park@lge.com \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.