From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754392AbcCVGNS (ORCPT ); Tue, 22 Mar 2016 02:13:18 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34796 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbcCVGMw (ORCPT ); Tue, 22 Mar 2016 02:12:52 -0400 From: Ming Lei To: Jens Axboe , linux-kernel@vger.kernel.org Cc: linux-block@vger.kernel.org, Christoph Hellwig , Al Viro , Anton Altaparmakov , xfs@oss.sgi.com, Dave Chinner , drbd-dev@lists.linbit.com, Philipp Reisner , Lars Ellenberg , Boaz Harrosh , Ming Lei Subject: [PATCH 3/8] block: mark 1st parameter of bvec_iter_advance as const Date: Tue, 22 Mar 2016 14:12:24 +0800 Message-Id: <1458627149-12988-4-git-send-email-ming.lei@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> References: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org bvec_iter_advance() only writes the parameter of iterator, so the base address of bvec can be marked as const safely. Without the change, we can see compiling warning in the following patch for implementing iterate_bvec(): lib/iov_iter.c with bvec iterator. Signed-off-by: Ming Lei --- include/linux/bvec_iter.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/bvec_iter.h b/include/linux/bvec_iter.h index cc43055..5798c21 100644 --- a/include/linux/bvec_iter.h +++ b/include/linux/bvec_iter.h @@ -49,7 +49,8 @@ .bv_offset = bvec_iter_offset((bvec), (iter)), \ }) -static inline void bvec_iter_advance(struct bio_vec *bv, struct bvec_iter *iter, +static inline void bvec_iter_advance(const struct bio_vec *bv, + struct bvec_iter *iter, unsigned bytes) { WARN_ONCE(bytes > iter->bi_size, -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 5E30F7CA4 for ; Tue, 22 Mar 2016 01:12:54 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 2D292304051 for ; Mon, 21 Mar 2016 23:12:54 -0700 (PDT) Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by cuda.sgi.com with ESMTP id wV0wSC3fDN6BcPhH (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Mon, 21 Mar 2016 23:12:51 -0700 (PDT) Received: by mail-pf0-f194.google.com with SMTP id n5so33916050pfn.1 for ; Mon, 21 Mar 2016 23:12:51 -0700 (PDT) From: Ming Lei Subject: [PATCH 3/8] block: mark 1st parameter of bvec_iter_advance as const Date: Tue, 22 Mar 2016 14:12:24 +0800 Message-Id: <1458627149-12988-4-git-send-email-ming.lei@canonical.com> In-Reply-To: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> References: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jens Axboe , linux-kernel@vger.kernel.org Cc: Christoph Hellwig , Boaz Harrosh , Ming Lei , Philipp Reisner , xfs@oss.sgi.com, linux-block@vger.kernel.org, Al Viro , Lars Ellenberg , Anton Altaparmakov , drbd-dev@lists.linbit.com bvec_iter_advance() only writes the parameter of iterator, so the base address of bvec can be marked as const safely. Without the change, we can see compiling warning in the following patch for implementing iterate_bvec(): lib/iov_iter.c with bvec iterator. Signed-off-by: Ming Lei --- include/linux/bvec_iter.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/bvec_iter.h b/include/linux/bvec_iter.h index cc43055..5798c21 100644 --- a/include/linux/bvec_iter.h +++ b/include/linux/bvec_iter.h @@ -49,7 +49,8 @@ .bv_offset = bvec_iter_offset((bvec), (iter)), \ }) -static inline void bvec_iter_advance(struct bio_vec *bv, struct bvec_iter *iter, +static inline void bvec_iter_advance(const struct bio_vec *bv, + struct bvec_iter *iter, unsigned bytes) { WARN_ONCE(bytes > iter->bi_size, -- 1.9.1 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs