All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhe Tao <zhe.tao@intel.com>
To: dev@dpdk.org
Cc: zhe.tao@intel.com
Subject: [PATCH] i40e: fix ipv6 TSO issue for tx function
Date: Tue, 22 Mar 2016 21:13:45 +0800	[thread overview]
Message-ID: <1458652425-6167-1-git-send-email-zhe.tao@intel.com> (raw)

Issue:
when using the following CLI in testpmd to enable ipv6 TSO feature
=============
set verbose 1
csum set ip hw 0
csum set udp hw 0
csum set tcp hw 0
csum set sctp hw 0
csum set outer-ip hw 0
csum parse_tunnel on 0
tso set 800 0
set fwd csum

start
=============

We will not get we want, the ipv6 packets sent out from IXIA can be received by
i40e, but cannot forward to another port.
The root cause is when HW doing the TSO offload for packets, it not only depends
on the context descriptor to define the MSS and TSO payload size, it also
need to know whether this packets is ipv4 or ipv6, ipv4 need the header csum,
but ipv6 doesn't need the csum. We need to use the i40e_txd_enable_checksum to
set the ipv6 type flag into the data descriptor when the packets are for
ipv6 TSO.  
 
Fixes: e3f0151f (i40e: enable Tx checksum only for offloaded packets)

Signed-off-by: Zhe Tao <zhe.tao@intel.com>
---
 drivers/net/i40e/i40e_rxtx.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 1488f2f..ffd6dba 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1545,6 +1545,7 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 	uint16_t slen;
 	uint64_t buf_dma_addr;
 	union i40e_tx_offload tx_offload = {0};
+	bool enable_checksum = 0;
 
 	txq = tx_queue;
 	sw_ring = txq->sw_ring;
@@ -1620,7 +1621,13 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 
 		/* Enable checksum offloading */
 		cd_tunneling_params = 0;
-		if (ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK) {
+		/* Check whether need to do checksum or not */
+		if ((ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK) ||
+		    ((ol_flags & PKT_TX_IPV6) && (ol_flags & PKT_TX_TCP_SEG))) {
+			enable_checksum = 1;
+		}
+
+		if (enable_checksum) {
 			i40e_txd_enable_checksum(ol_flags, &td_cmd, &td_offset,
 				tx_offload, &cd_tunneling_params);
 		}
-- 
2.1.4

             reply	other threads:[~2016-03-22 13:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 13:13 Zhe Tao [this message]
2016-03-22 13:38 ` [PATCH] i40e: fix ipv6 TSO issue for tx function Ananyev, Konstantin
2016-03-22 18:41   ` Zhe Tao
2016-03-23  3:27 ` [PATCH v2] " Zhe Tao
2016-03-23 12:46   ` Ananyev, Konstantin
2016-03-24 14:58   ` Bruce Richardson
2016-03-24 15:00   ` Bruce Richardson
2016-03-31  3:58     ` Zhe Tao
2016-03-31 12:15   ` [PATCH v3] i40e: fix " Zhe Tao
2016-03-31 12:18     ` Bruce Richardson
2016-04-06  8:16     ` [PATCH v4] " Zhe Tao
2016-04-06 11:23       ` Ananyev, Konstantin
2016-04-06 13:43         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458652425-6167-1-git-send-email-zhe.tao@intel.com \
    --to=zhe.tao@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.