From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 10/15] drm/i915: Move fp divisor calculation into ironlake_compute_dpll() Date: Tue, 22 Mar 2016 15:22:26 +0200 Message-ID: <1458652946.2716.2.camel@gmail.com> References: <1458576016-30348-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1458576016-30348-11-git-send-email-ander.conselvan.de.oliveira@intel.com> <20160322124911.GK4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-x236.google.com (mail-pf0-x236.google.com [IPv6:2607:f8b0:400e:c00::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id A82756E309 for ; Tue, 22 Mar 2016 13:22:32 +0000 (UTC) Received: by mail-pf0-x236.google.com with SMTP id n5so311528658pfn.2 for ; Tue, 22 Mar 2016 06:22:32 -0700 (PDT) In-Reply-To: <20160322124911.GK4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE2LTAzLTIyIGF0IDE0OjQ5ICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gTW9uLCBNYXIgMjEsIDIwMTYgYXQgMDY6MDA6MTFQTSArMDIwMCwgQW5kZXIgQ29uc2Vs dmFuIGRlIE9saXZlaXJhIHdyb3RlOgo+ID4gRm9sbG93IHdoYXQgaXMgZG9uZSBpbiBpOHh4X2Nv bXB1dGVfZHBsbCgpIGFuZCBpOXh4X2NvbXB1dGVfZHBsbCgpIGFuZAo+ID4gbW92ZSB0aGUgbG93 ZXIgbGV2ZWwgZGV0YWlscyBvZiBzZXR0aW5nIGNydGNfc3RhdGUtPmRwbGxfaHdfc3RhdGUgaW50 bwo+ID4gdGhlIF9jb21wdXRlX2RwbGwoKSBmdW5jdGlvbi4KPiAKPiBNaXNzaW5nIHNvYi4KCk9v cHMsCgpTaWduZWQtb2ZmLWJ5OiBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGFuZGVyLmNv bnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5jb20+CgoKPiBSZXZpZXdlZC1ieTogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiA+IC0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQ1ICsrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLQo+ID4gLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlv bnMoKyksIDIzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+ID4gaW5kZXggMGI2ZWFiZi4uYjY1NDFhMCAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtODgyMSwxMCArODgyMSw5IEBAIHN0YXRp YyBib29sIGlyb25sYWtlX25lZWRzX2ZiX2NiX3R1bmUoc3RydWN0IGRwbGwKPiA+ICpkcGxsLCBp bnQgZmFjdG9yKQo+ID4gIAlyZXR1cm4gaTl4eF9kcGxsX2NvbXB1dGVfbShkcGxsKSA8IGZhY3Rv ciAqIGRwbGwtPm47Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyB1aW50MzJfdCBpcm9ubGFrZV9j b21wdXRlX2RwbGwoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4gPiAtCQkJCSAgICAg IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ID4gLQkJCQkgICAgICB1MzIg KmZwLAo+ID4gLQkJCQkgICAgICBpbnRlbF9jbG9ja190ICpyZWR1Y2VkX2Nsb2NrLCB1MzIKPiA+ ICpmcDIpCj4gPiArc3RhdGljIHZvaWQgaXJvbmxha2VfY29tcHV0ZV9kcGxsKHN0cnVjdCBpbnRl bF9jcnRjICppbnRlbF9jcnRjLAo+ID4gKwkJCQkgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpj cnRjX3N0YXRlLAo+ID4gKwkJCQkgIGludGVsX2Nsb2NrX3QgKnJlZHVjZWRfY2xvY2spCj4gPiAg ewo+ID4gIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSAmaW50ZWxfY3J0Yy0+YmFzZTsKPiA+ICAJ c3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmRldjsKPiA+IEBAIC04ODMzLDcgKzg4MzIs NyBAQCBzdGF0aWMgdWludDMyX3QgaXJvbmxha2VfY29tcHV0ZV9kcGxsKHN0cnVjdAo+ID4gaW50 ZWxfY3J0YyAqaW50ZWxfY3J0YywKPiA+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rv cjsKPiA+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5lY3Rvcl9zdGF0ZTsKPiA+ ICAJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXI7Cj4gPiAtCXVpbnQzMl90IGRwbGw7Cj4g PiArCXUzMiBkcGxsLCBmcCwgZnAyOwo+ID4gIAlpbnQgZmFjdG9yLCBpOwo+ID4gIAlib29sIGlz X2x2ZHMgPSBmYWxzZSwgaXNfc2R2byA9IGZhbHNlOwo+ID4gIAo+ID4gQEAgLTg4NjYsMTEgKzg4 NjUsMTkgQEAgc3RhdGljIHVpbnQzMl90IGlyb25sYWtlX2NvbXB1dGVfZHBsbChzdHJ1Y3QKPiA+ IGludGVsX2NydGMgKmludGVsX2NydGMsCj4gPiAgCX0gZWxzZSBpZiAoY3J0Y19zdGF0ZS0+c2R2 b190dl9jbG9jaykKPiA+ICAJCWZhY3RvciA9IDIwOwo+ID4gIAo+ID4gKwlmcCA9IGk5eHhfZHBs bF9jb21wdXRlX2ZwKCZjcnRjX3N0YXRlLT5kcGxsKTsKPiA+ICsKPiA+ICAJaWYgKGlyb25sYWtl X25lZWRzX2ZiX2NiX3R1bmUoJmNydGNfc3RhdGUtPmRwbGwsIGZhY3RvcikpCj4gPiAtCQkqZnAg fD0gRlBfQ0JfVFVORTsKPiA+ICsJCWZwIHw9IEZQX0NCX1RVTkU7Cj4gPiArCj4gPiArCWlmIChy ZWR1Y2VkX2Nsb2NrKSB7Cj4gPiArCQlmcDIgPSBpOXh4X2RwbGxfY29tcHV0ZV9mcChyZWR1Y2Vk X2Nsb2NrKTsKPiA+ICAKPiA+IC0JaWYgKGZwMiAmJiAocmVkdWNlZF9jbG9jay0+bSA8IGZhY3Rv ciAqIHJlZHVjZWRfY2xvY2stPm4pKQo+ID4gLQkJKmZwMiB8PSBGUF9DQl9UVU5FOwo+ID4gKwkJ aWYgKHJlZHVjZWRfY2xvY2stPm0gPCBmYWN0b3IgKiByZWR1Y2VkX2Nsb2NrLT5uKQo+ID4gKwkJ CWZwMiB8PSBGUF9DQl9UVU5FOwo+ID4gKwl9IGVsc2Ugewo+ID4gKwkJZnAyID0gZnA7Cj4gPiAr CX0KPiA+ICAKPiA+ICAJZHBsbCA9IDA7Cj4gPiAgCj4gPiBAQCAtODkxMiwxNCArODkxOSwxNyBA QCBzdGF0aWMgdWludDMyX3QgaXJvbmxha2VfY29tcHV0ZV9kcGxsKHN0cnVjdAo+ID4gaW50ZWxf Y3J0YyAqaW50ZWxfY3J0YywKPiA+ICAJZWxzZQo+ID4gIAkJZHBsbCB8PSBQTExfUkVGX0lOUFVU X0RSRUZDTEs7Cj4gPiAgCj4gPiAtCXJldHVybiBkcGxsIHwgRFBMTF9WQ09fRU5BQkxFOwo+ID4g KwlkcGxsIHw9IERQTExfVkNPX0VOQUJMRTsKPiA+ICsKPiA+ICsJY3J0Y19zdGF0ZS0+ZHBsbF9o d19zdGF0ZS5kcGxsID0gZHBsbDsKPiA+ICsJY3J0Y19zdGF0ZS0+ZHBsbF9od19zdGF0ZS5mcDAg PSBmcDsKPiA+ICsJY3J0Y19zdGF0ZS0+ZHBsbF9od19zdGF0ZS5mcDEgPSBmcDI7Cj4gPiAgfQo+ ID4gIAo+ID4gIHN0YXRpYyBpbnQgaXJvbmxha2VfY3J0Y19jb21wdXRlX2Nsb2NrKHN0cnVjdCBp bnRlbF9jcnRjICpjcnRjLAo+ID4gIAkJCQkgICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUg KmNydGNfc3RhdGUpCj4gPiAgewo+ID4gIAlpbnRlbF9jbG9ja190IHJlZHVjZWRfY2xvY2s7Cj4g PiAtCXUzMiBkcGxsID0gMCwgZnAgPSAwLCBmcDIgPSAwOwo+ID4gIAlib29sIGhhc19yZWR1Y2Vk X2Nsb2NrID0gZmFsc2U7Cj4gPiAgCXN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsOwo+ID4g IAo+ID4gQEAgLTg5NDEsMTkgKzg5NTEsOCBAQCBzdGF0aWMgaW50IGlyb25sYWtlX2NydGNfY29t cHV0ZV9jbG9jayhzdHJ1Y3QKPiA+IGludGVsX2NydGMgKmNydGMsCj4gPiAgCQlyZXR1cm4gLUVJ TlZBTDsKPiA+ICAJfQo+ID4gIAo+ID4gLQlmcCA9IGk5eHhfZHBsbF9jb21wdXRlX2ZwKCZjcnRj X3N0YXRlLT5kcGxsKTsKPiA+IC0JaWYgKGhhc19yZWR1Y2VkX2Nsb2NrKQo+ID4gLQkJZnAyID0g aTl4eF9kcGxsX2NvbXB1dGVfZnAoJnJlZHVjZWRfY2xvY2spOwo+ID4gLQllbHNlCj4gPiAtCQlm cDIgPSBmcDsKPiA+IC0KPiA+IC0JZHBsbCA9IGlyb25sYWtlX2NvbXB1dGVfZHBsbChjcnRjLCBj cnRjX3N0YXRlLAo+ID4gLQkJCQkgICAgICZmcCwgJnJlZHVjZWRfY2xvY2ssCj4gPiAtCQkJCSAg ICAgaGFzX3JlZHVjZWRfY2xvY2sgPyAmZnAyIDogTlVMTCk7Cj4gPiAtCj4gPiAtCWNydGNfc3Rh dGUtPmRwbGxfaHdfc3RhdGUuZHBsbCA9IGRwbGw7Cj4gPiAtCWNydGNfc3RhdGUtPmRwbGxfaHdf c3RhdGUuZnAwID0gZnA7Cj4gPiAtCWNydGNfc3RhdGUtPmRwbGxfaHdfc3RhdGUuZnAxID0gZnAy Owo+ID4gKwlpcm9ubGFrZV9jb21wdXRlX2RwbGwoY3J0YywgY3J0Y19zdGF0ZSwKPiA+ICsJCQkg ICAgICBoYXNfcmVkdWNlZF9jbG9jayA/ICZyZWR1Y2VkX2Nsb2NrIDogTlVMTCk7Cj4gPiAgCj4g PiAgCXBsbCA9IGludGVsX2dldF9zaGFyZWRfZHBsbChjcnRjLCBjcnRjX3N0YXRlLCBOVUxMKTsK PiA+ICAJaWYgKHBsbCA9PSBOVUxMKSB7Cj4gPiAtLSAKPiA+IDIuNC4zCj4gPiAKPiA+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK