From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: [PATCH v2 1/7] app/test/test: Fix missing brackets Date: Tue, 22 Mar 2016 17:37:12 -0400 Message-ID: <1458682638-28378-2-git-send-email-aconole@redhat.com> References: <1458682638-28378-1-git-send-email-aconole@redhat.com> To: dev@dpdk.org, Bruce Richardson , Thomas Monjalon , Helin Zhang , Wenzhuo Lu , Panu Matilainen , Remy Horton Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8DCD35599 for ; Tue, 22 Mar 2016 22:37:21 +0100 (CET) In-Reply-To: <1458682638-28378-1-git-send-email-aconole@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The test application calls printf(...) with the suite->suite_name argument. The intent (based on whitespace) in the printf is to check suite->suite_name first and then apply the printf. This doesn't happen due to missing brackets. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen --- v2: * No change (apart from adding ACKs) app/test/test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test.c b/app/test/test.c index f35b304..ccad0e3 100644 --- a/app/test/test.c +++ b/app/test/test.c @@ -162,9 +162,10 @@ unit_test_suite_runner(struct unit_test_suite *suite) int test_success; unsigned total = 0, executed = 0, skipped = 0, succeeded = 0, failed = 0; - if (suite->suite_name) + if (suite->suite_name) { printf(" + ------------------------------------------------------- +\n"); printf(" + Test Suite : %s\n", suite->suite_name); + } if (suite->setup) if (suite->setup() != 0) -- 2.8.0.rc2.35.gc2c5f6b.dirty