From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: [PATCH v2 4/7] drivers/net/ixgbe: Fix vlan filter missing brackets Date: Tue, 22 Mar 2016 17:37:15 -0400 Message-ID: <1458682638-28378-5-git-send-email-aconole@redhat.com> References: <1458682638-28378-1-git-send-email-aconole@redhat.com> To: dev@dpdk.org, Bruce Richardson , Thomas Monjalon , Helin Zhang , Wenzhuo Lu , Panu Matilainen , Remy Horton Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2C9235680 for ; Tue, 22 Mar 2016 22:37:24 +0100 (CET) In-Reply-To: <1458682638-28378-1-git-send-email-aconole@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ixgbe vlan filter code has an if check with an incorrect whitespace. Signed-off-by: Aaron Conole Acked-by: Panu Matilainen Acked-by: Helin Zhang --- v2: * No change (apart from adding ACKs) drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index d4d883a..e290bce 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4377,10 +4377,11 @@ ixgbe_set_pool_vlan_filter(struct rte_eth_dev *dev, uint16_t vlan, if (ixgbe_vmdq_mode_check(hw) < 0) return -ENOTSUP; for (pool_idx = 0; pool_idx < ETH_64_POOLS; pool_idx++) { - if (pool_mask & ((uint64_t)(1ULL << pool_idx))) + if (pool_mask & ((uint64_t)(1ULL << pool_idx))) { ret = hw->mac.ops.set_vfta(hw,vlan,pool_idx,vlan_on); if (ret < 0) return ret; + } } return ret; -- 2.8.0.rc2.35.gc2c5f6b.dirty