* [PATCH] nfs-utils: bugfix: adjust name of statd service unit
@ 2016-02-17 9:30 Ulrich Ölmann
2016-03-23 0:34 ` Dan McGregor
2016-03-24 21:48 ` Burton, Ross
0 siblings, 2 replies; 8+ messages in thread
From: Ulrich Ölmann @ 2016-02-17 9:30 UTC (permalink / raw)
To: openembedded-core
Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
'nfs-statd.service' instead but forgot to update the mount.nfs helper
'start-statd' accordingly.
Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
---
.../files/bugfix-adjust-statd-service-name.patch | 34 ++++++++++++++++++++++
.../nfs-utils/nfs-utils_1.3.3.bb | 1 +
2 files changed, 35 insertions(+)
create mode 100644 meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
diff --git a/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
new file mode 100644
index 0000000..14bd403
--- /dev/null
+++ b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
@@ -0,0 +1,34 @@
+From 398fed3bb0350cb1229e54e7020ae0e044c206d1 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Ulrich=20=C3=96lmann?= <u.oelmann@pengutronix.de>
+Date: Wed, 17 Feb 2016 08:33:45 +0100
+Subject: bugfix: adjust statd service name
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Upstream uses 'rpc-statd.service' and Yocto introduced 'nfs-statd.service'
+instead but forgot to update the mount.nfs helper 'start-statd' accordingly.
+
+Upstream-Status: Inappropriate [other]
+
+Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
+---
+ utils/statd/start-statd | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/utils/statd/start-statd b/utils/statd/start-statd
+index 8211a90..3c2aa6f 100755
+--- a/utils/statd/start-statd
++++ b/utils/statd/start-statd
+@@ -16,7 +16,7 @@ fi
+ # First try systemd if it's installed.
+ if [ -d /run/systemd/system ]; then
+ # Quit only if the call worked.
+- systemctl start rpc-statd.service && exit
++ systemctl start nfs-statd.service && exit
+ fi
+
+ # Fall back to launching it ourselves.
+--
+2.1.4
+
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
index ea00656..a6268f3 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
@@ -32,6 +32,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x
file://nfs-utils-Do-not-pass-CFLAGS-to-gcc-while-building.patch \
file://nfs-utils-debianize-start-statd.patch \
file://0001-nfs-utils-statd-fix-a-segfault-caused-by-improper-us.patch \
+ file://bugfix-adjust-statd-service-name.patch \
"
SRC_URI[md5sum] = "cd6b568c2e9301cc3bfac09d87fbbc0b"
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] nfs-utils: bugfix: adjust name of statd service unit
2016-02-17 9:30 [PATCH] nfs-utils: bugfix: adjust name of statd service unit Ulrich Ölmann
@ 2016-03-23 0:34 ` Dan McGregor
2016-03-23 8:47 ` Ulrich Ölmann
2016-03-24 21:48 ` Burton, Ross
1 sibling, 1 reply; 8+ messages in thread
From: Dan McGregor @ 2016-03-23 0:34 UTC (permalink / raw)
To: Ulrich Ölmann; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 3205 bytes --]
On 17 Feb 2016 3:48 a.m., "Ulrich Ölmann" <u.oelmann@pengutronix.de> wrote:
>
> Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
> 'nfs-statd.service' instead but forgot to update the mount.nfs helper
> 'start-statd' accordingly.
>
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
> .../files/bugfix-adjust-statd-service-name.patch | 34
++++++++++++++++++++++
> .../nfs-utils/nfs-utils_1.3.3.bb | 1 +
> 2 files changed, 35 insertions(+)
> create mode 100644
meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
>
> diff --git
a/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
> new file mode 100644
> index 0000000..14bd403
> --- /dev/null
> +++
b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
> @@ -0,0 +1,34 @@
> +From 398fed3bb0350cb1229e54e7020ae0e044c206d1 Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?Ulrich=20=C3=96lmann?= <u.oelmann@pengutronix.de>
> +Date: Wed, 17 Feb 2016 08:33:45 +0100
> +Subject: bugfix: adjust statd service name
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Upstream uses 'rpc-statd.service' and Yocto introduced
'nfs-statd.service'
> +instead but forgot to update the mount.nfs helper 'start-statd'
accordingly.
> +
> +Upstream-Status: Inappropriate [other]
> +
> +Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> +---
> + utils/statd/start-statd | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/utils/statd/start-statd b/utils/statd/start-statd
> +index 8211a90..3c2aa6f 100755
> +--- a/utils/statd/start-statd
> ++++ b/utils/statd/start-statd
> +@@ -16,7 +16,7 @@ fi
> + # First try systemd if it's installed.
> + if [ -d /run/systemd/system ]; then
> + # Quit only if the call worked.
> +- systemctl start rpc-statd.service && exit
> ++ systemctl start nfs-statd.service && exit
> + fi
> +
> + # Fall back to launching it ourselves.
> +--
> +2.1.4
> +
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
> index ea00656..a6268f3 100644
> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.3.bb
> @@ -32,6 +32,7 @@ SRC_URI =
"${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x
>
file://nfs-utils-Do-not-pass-CFLAGS-to-gcc-while-building.patch \
> file://nfs-utils-debianize-start-statd.patch \
>
file://0001-nfs-utils-statd-fix-a-segfault-caused-by-improper-us.patch \
> + file://bugfix-adjust-statd-service-name.patch \
> "
>
> SRC_URI[md5sum] = "cd6b568c2e9301cc3bfac09d87fbbc0b"
> --
> 2.7.0
>
> --
>
I just got bit by this in jethro. Can it be backported?
_______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
[-- Attachment #2: Type: text/html, Size: 4479 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] nfs-utils: bugfix: adjust name of statd service unit
2016-03-23 0:34 ` Dan McGregor
@ 2016-03-23 8:47 ` Ulrich Ölmann
2016-03-23 8:47 ` [jethro][PATCH] " Ulrich Ölmann
2016-03-23 13:18 ` [PATCH] " Dan McGregor
0 siblings, 2 replies; 8+ messages in thread
From: Ulrich Ölmann @ 2016-03-23 8:47 UTC (permalink / raw)
To: Dan McGregor; +Cc: Patches and discussions about the oe-core layer
Hi Dan,
On Tue, Mar 22, 2016 at 06:34:08PM -0600, Dan McGregor wrote:
> On 17 Feb 2016 3:48 a.m., "Ulrich Ölmann" <u.oelmann@pengutronix.de> wrote:
> >
> > Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
> > 'nfs-statd.service' instead but forgot to update the mount.nfs helper
> > 'start-statd' accordingly.
> >
> > Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> > ---
> > .../files/bugfix-adjust-statd-service-name.patch | 34
> ++++++++++++++++++++++
> > .../nfs-utils/nfs-utils_1.3.3.bb | 1 +
> > 2 files changed, 35 insertions(+)
> > create mode 100644
> meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
[...]
> I just got bit by this in jethro. Can it be backported?
Backporting should be fairly simple, I assume you didn't give it a go.
Try the patch that comes in my reply to this mail. It is untested as I don't
have the time at the moment, hence please report back if it works.
Regards
Ulrich
^ permalink raw reply [flat|nested] 8+ messages in thread
* [jethro][PATCH] nfs-utils: bugfix: adjust name of statd service unit
2016-03-23 8:47 ` Ulrich Ölmann
@ 2016-03-23 8:47 ` Ulrich Ölmann
2016-03-23 13:18 ` [PATCH] " Dan McGregor
1 sibling, 0 replies; 8+ messages in thread
From: Ulrich Ölmann @ 2016-03-23 8:47 UTC (permalink / raw)
To: Dan McGregor; +Cc: Patches and discussions about the oe-core layer
Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
'nfs-statd.service' instead but forgot to update the mount.nfs helper
'start-statd' accordingly.
Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
---
.../files/bugfix-adjust-statd-service-name.patch | 34 ++++++++++++++++++++++
.../nfs-utils/nfs-utils_1.3.1.bb | 1 +
2 files changed, 35 insertions(+)
create mode 100644 meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
diff --git a/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
new file mode 100644
index 0000000..14bd403
--- /dev/null
+++ b/meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
@@ -0,0 +1,34 @@
+From 398fed3bb0350cb1229e54e7020ae0e044c206d1 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Ulrich=20=C3=96lmann?= <u.oelmann@pengutronix.de>
+Date: Wed, 17 Feb 2016 08:33:45 +0100
+Subject: bugfix: adjust statd service name
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Upstream uses 'rpc-statd.service' and Yocto introduced 'nfs-statd.service'
+instead but forgot to update the mount.nfs helper 'start-statd' accordingly.
+
+Upstream-Status: Inappropriate [other]
+
+Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
+---
+ utils/statd/start-statd | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/utils/statd/start-statd b/utils/statd/start-statd
+index 8211a90..3c2aa6f 100755
+--- a/utils/statd/start-statd
++++ b/utils/statd/start-statd
+@@ -16,7 +16,7 @@ fi
+ # First try systemd if it's installed.
+ if [ -d /run/systemd/system ]; then
+ # Quit only if the call worked.
+- systemctl start rpc-statd.service && exit
++ systemctl start nfs-statd.service && exit
+ fi
+
+ # Fall back to launching it ourselves.
+--
+2.1.4
+
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.1.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.1.bb
index 42101de..f346fdc 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.1.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.3.1.bb
@@ -31,6 +31,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x
file://proc-fs-nfsd.mount \
file://nfs-utils-Do-not-pass-CFLAGS-to-gcc-while-building.patch \
file://nfs-utils-debianize-start-statd.patch \
+ file://bugfix-adjust-statd-service-name.patch \
"
SRC_URI[md5sum] = "8de676b9ff34b8f9addc1d0800fabdf8"
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] nfs-utils: bugfix: adjust name of statd service unit
2016-03-23 8:47 ` Ulrich Ölmann
2016-03-23 8:47 ` [jethro][PATCH] " Ulrich Ölmann
@ 2016-03-23 13:18 ` Dan McGregor
2016-03-23 13:38 ` Ulrich Ölmann
1 sibling, 1 reply; 8+ messages in thread
From: Dan McGregor @ 2016-03-23 13:18 UTC (permalink / raw)
To: Ulrich Ölmann; +Cc: Patches and discussions about the oe-core layer
On 23 March 2016 at 02:47, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
> Hi Dan,
>
> On Tue, Mar 22, 2016 at 06:34:08PM -0600, Dan McGregor wrote:
>> On 17 Feb 2016 3:48 a.m., "Ulrich Ölmann" <u.oelmann@pengutronix.de> wrote:
>> >
>> > Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
>> > 'nfs-statd.service' instead but forgot to update the mount.nfs helper
>> > 'start-statd' accordingly.
>> >
>> > Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
>> > ---
>> > .../files/bugfix-adjust-statd-service-name.patch | 34
>> ++++++++++++++++++++++
>> > .../nfs-utils/nfs-utils_1.3.3.bb | 1 +
>> > 2 files changed, 35 insertions(+)
>> > create mode 100644
>> meta/recipes-connectivity/nfs-utils/files/bugfix-adjust-statd-service-name.patch
>
> [...]
>
>> I just got bit by this in jethro. Can it be backported?
>
> Backporting should be fairly simple, I assume you didn't give it a go.
> Try the patch that comes in my reply to this mail. It is untested as I don't
> have the time at the moment, hence please report back if it works.
>
Oh, I did backport it locally, I was just hoping to get it into the
upstream jethro branch. Cherry picking your commit was pretty
straightforward.
Thanks,
Dan
> Regards
> Ulrich
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] nfs-utils: bugfix: adjust name of statd service unit
2016-03-23 13:18 ` [PATCH] " Dan McGregor
@ 2016-03-23 13:38 ` Ulrich Ölmann
0 siblings, 0 replies; 8+ messages in thread
From: Ulrich Ölmann @ 2016-03-23 13:38 UTC (permalink / raw)
To: Dan McGregor; +Cc: Patches and discussions about the oe-core layer
On Wed, Mar 23, 2016 at 07:18:38AM -0600, Dan McGregor wrote:
> Oh, I did backport it locally, I was just hoping to get it into the
> upstream jethro branch.
Let's see what upstream decides.
> Cherry picking your commit was pretty straightforward.
:)
Regards
Ulrich
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] nfs-utils: bugfix: adjust name of statd service unit
2016-02-17 9:30 [PATCH] nfs-utils: bugfix: adjust name of statd service unit Ulrich Ölmann
2016-03-23 0:34 ` Dan McGregor
@ 2016-03-24 21:48 ` Burton, Ross
2016-03-24 22:11 ` Dan McGregor
1 sibling, 1 reply; 8+ messages in thread
From: Burton, Ross @ 2016-03-24 21:48 UTC (permalink / raw)
To: Ulrich Ölmann; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
On 17 February 2016 at 09:30, Ulrich Ölmann <u.oelmann@pengutronix.de>
wrote:
> Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
> 'nfs-statd.service' instead but forgot to update the mount.nfs helper
> 'start-statd' accordingly.
>
Having less patches seems sensible, so would it be simple if we move to the
upstream names instead of away from upstream?
Ross
[-- Attachment #2: Type: text/html, Size: 823 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] nfs-utils: bugfix: adjust name of statd service unit
2016-03-24 21:48 ` Burton, Ross
@ 2016-03-24 22:11 ` Dan McGregor
0 siblings, 0 replies; 8+ messages in thread
From: Dan McGregor @ 2016-03-24 22:11 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 24 March 2016 at 15:48, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 17 February 2016 at 09:30, Ulrich Ölmann <u.oelmann@pengutronix.de>
> wrote:
>>
>> Upstream nfs-utils use 'rpc-statd.service' and Yocto introduced
>> 'nfs-statd.service' instead but forgot to update the mount.nfs helper
>> 'start-statd' accordingly.
>
>
> Having less patches seems sensible, so would it be simple if we move to the
> upstream names instead of away from upstream?
>
I think that's sensible. The upstream services are there in the
distfile, we'd just need to install them.
> Ross
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-03-24 22:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-17 9:30 [PATCH] nfs-utils: bugfix: adjust name of statd service unit Ulrich Ölmann
2016-03-23 0:34 ` Dan McGregor
2016-03-23 8:47 ` Ulrich Ölmann
2016-03-23 8:47 ` [jethro][PATCH] " Ulrich Ölmann
2016-03-23 13:18 ` [PATCH] " Dan McGregor
2016-03-23 13:38 ` Ulrich Ölmann
2016-03-24 21:48 ` Burton, Ross
2016-03-24 22:11 ` Dan McGregor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.