From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= Subject: [RFC v1 08/17] selftest/seccomp: Remove unknown_ret_is_kill_above_allow test Date: Thu, 24 Mar 2016 02:46:39 +0100 Message-ID: <1458784008-16277-9-git-send-email-mic@digikod.net> References: <1458784008-16277-1-git-send-email-mic@digikod.net> Reply-To: kernel-hardening@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <1458784008-16277-1-git-send-email-mic@digikod.net> To: linux-security-module@vger.kernel.org Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Andreas Gruenbacher , Andy Lutomirski , Andy Lutomirski , Arnd Bergmann , Casey Schaufler , Daniel Borkmann , David Drysdale , Eric Paris , James Morris , Jeff Dike , Julien Tinnes , Kees Cook , Michael Kerrisk , Paul Moore , Richard Weinberger , "Serge E . Hallyn" , Stephen Smalley , Tetsuo Handa , Will Drewry , linux-api@vger.kernel.org, kernel-hardening@lists.openwall.com List-Id: linux-api@vger.kernel.org This is not relevant anymore because of SECCOMP_RET_INTER. Signed-off-by: Mickaël Salaün --- tools/testing/selftests/seccomp/seccomp_bpf.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 150829dd7998..023717bf3185 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -363,28 +363,6 @@ TEST_SIGNAL(unknown_ret_is_kill_inside, SIGSYS) } } -/* return code >= 0x80000000 is unused. */ -TEST_SIGNAL(unknown_ret_is_kill_above_allow, SIGSYS) -{ - struct sock_filter filter[] = { - BPF_STMT(BPF_RET|BPF_K, 0x90000000U), - }; - struct sock_fprog prog = { - .len = (unsigned short)ARRAY_SIZE(filter), - .filter = filter, - }; - long ret; - - ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0); - ASSERT_EQ(0, ret); - - ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog); - ASSERT_EQ(0, ret); - EXPECT_EQ(0, syscall(__NR_getpid)) { - TH_LOG("getpid() shouldn't ever return"); - } -} - TEST_SIGNAL(KILL_all, SIGSYS) { struct sock_filter filter[] = { -- 2.8.0.rc3 From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com From: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= Date: Thu, 24 Mar 2016 02:46:39 +0100 Message-Id: <1458784008-16277-9-git-send-email-mic@digikod.net> In-Reply-To: <1458784008-16277-1-git-send-email-mic@digikod.net> References: <1458784008-16277-1-git-send-email-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [kernel-hardening] [RFC v1 08/17] selftest/seccomp: Remove unknown_ret_is_kill_above_allow test To: linux-security-module@vger.kernel.org Cc: =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , Andreas Gruenbacher , Andy Lutomirski , Andy Lutomirski , Arnd Bergmann , Casey Schaufler , Daniel Borkmann , David Drysdale , Eric Paris , James Morris , Jeff Dike , Julien Tinnes , Kees Cook , Michael Kerrisk , Paul Moore , Richard Weinberger , "Serge E . Hallyn" , Stephen Smalley , Tetsuo Handa , Will Drewry , linux-api@vger.kernel.org, kernel-hardening@lists.openwall.com List-ID: This is not relevant anymore because of SECCOMP_RET_INTER. Signed-off-by: Mickaël Salaün --- tools/testing/selftests/seccomp/seccomp_bpf.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 150829dd7998..023717bf3185 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -363,28 +363,6 @@ TEST_SIGNAL(unknown_ret_is_kill_inside, SIGSYS) } } -/* return code >= 0x80000000 is unused. */ -TEST_SIGNAL(unknown_ret_is_kill_above_allow, SIGSYS) -{ - struct sock_filter filter[] = { - BPF_STMT(BPF_RET|BPF_K, 0x90000000U), - }; - struct sock_fprog prog = { - .len = (unsigned short)ARRAY_SIZE(filter), - .filter = filter, - }; - long ret; - - ret = prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0); - ASSERT_EQ(0, ret); - - ret = prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog); - ASSERT_EQ(0, ret); - EXPECT_EQ(0, syscall(__NR_getpid)) { - TH_LOG("getpid() shouldn't ever return"); - } -} - TEST_SIGNAL(KILL_all, SIGSYS) { struct sock_filter filter[] = { -- 2.8.0.rc3