From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757980AbcCaWSd (ORCPT ); Thu, 31 Mar 2016 18:18:33 -0400 Received: from e28smtp03.in.ibm.com ([125.16.236.3]:43112 "EHLO e28smtp03.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757331AbcCaWSb (ORCPT ); Thu, 31 Mar 2016 18:18:31 -0400 X-IBM-Helo: d28relay03.in.ibm.com X-IBM-MailFrom: zohar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;keyrings@vger.kernel.org;linux-security-module@vger.kernel.org Message-ID: <1459462702.2657.61.camel@linux.vnet.ibm.com> Subject: Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #3] From: Mimi Zohar To: David Howells Cc: linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 31 Mar 2016 18:18:22 -0400 In-Reply-To: <1459439733.2657.41.camel@linux.vnet.ibm.com> References: <1459426888.2657.26.camel@linux.vnet.ibm.com> <1459166340.2751.52.camel@linux.vnet.ibm.com> <20160309111814.28811.95697.stgit@warthog.procyon.org.uk> <20160309111939.28811.7952.stgit@warthog.procyon.org.uk> <12767.1459354776@warthog.procyon.org.uk> <13142.1459437486@warthog.procyon.org.uk> <1459439733.2657.41.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 16033122-0009-0000-0000-00000BB75D91 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-03-31 at 11:55 -0400, Mimi Zohar wrote: > On Thu, 2016-03-31 at 16:18 +0100, David Howells wrote: > > Mimi Zohar wrote: > > > > > You said you didn't want this option above (to quote: In this patch, the > > > > choice should be between checking just the builtin trusted keys or both the > > > > builtin trusted and secondary keys.) > > > > > > Does the ability of adding builtin X.509 certificates directly to the > > > IMA keyring already exist or is it something that still needs to be > > > done? Assuming the latter, this option would be added with the ability > > > of adding X.509 certificates directly to the IMA keyring. > > > > I don't know what you mean by "directly" here. Even without this patch, you > > can already add X.509 certs to the .ima keyring, both at compile time > > I'm must be missing something obvious here. I need to review the > patches again. The builtin keys are loaded onto > the .builtin_trusted_keys keyring, not the IMA keyring.is the The only place where "KEY_ALLOC_BYPASS_RESTRICTION" is specified is in load_system_certificate_list(), when adding keys to the .builtin_trusted_keys keyring. There is no other set of keys builtin and added to the IMA keyring. Mimi