From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alx4A-00059I-6s for qemu-devel@nongnu.org; Fri, 01 Apr 2016 07:16:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alx49-0001jA-8x for qemu-devel@nongnu.org; Fri, 01 Apr 2016 07:16:38 -0400 Received: from mail-qk0-x235.google.com ([2607:f8b0:400d:c09::235]:34817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alx49-0001j5-4d for qemu-devel@nongnu.org; Fri, 01 Apr 2016 07:16:37 -0400 Received: by mail-qk0-x235.google.com with SMTP id o6so36594675qkc.2 for ; Fri, 01 Apr 2016 04:16:37 -0700 (PDT) Sender: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= From: marcandre.lureau@redhat.com Date: Fri, 1 Apr 2016 13:16:12 +0200 Message-Id: <1459509388-6185-3-git-send-email-marcandre.lureau@redhat.com> In-Reply-To: <1459509388-6185-1-git-send-email-marcandre.lureau@redhat.com> References: <1459509388-6185-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 02/18] char: lower reconnect error to trace event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Yuanhan Liu , "Michael S. Tsirkin" , Ilya Maximets , jonshin@cisco.com, Tetsuya Mukawa , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= From: Marc-André Lureau This message is an information rather than an error. Use a trace event instead. This allows using reconnect in tests without extra error messages. Signed-off-by: Marc-André Lureau --- qemu-char.c | 4 ++-- trace-events | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 270819a..a944ee0 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -40,6 +40,7 @@ #include "io/channel-file.h" #include "io/channel-tls.h" #include "sysemu/replay.h" +#include "trace.h" #include @@ -2639,8 +2640,7 @@ static void check_report_connect_error(CharDriverState *chr, TCPCharDriver *s = chr->opaque; if (!s->connect_err_reported) { - error_report("Unable to connect character device %s: %s", - chr->label, error_get_pretty(err)); + trace_char_socket_reconnect_error(chr->label, error_get_pretty(err)); s->connect_err_reported = true; } qemu_chr_socket_restart_timer(chr); diff --git a/trace-events b/trace-events index 996a77f..19e0a05 100644 --- a/trace-events +++ b/trace-events @@ -689,6 +689,9 @@ grlib_apbuart_readl_unknown(uint64_t addr) "addr 0x%"PRIx64 leon3_set_irq(int intno) "Set CPU IRQ %d" leon3_reset_irq(int intno) "Reset CPU IRQ %d" +# qemu-char.c +char_socket_reconnect_error(const char *label, const char *err) "Unable to connect character device %s: %s" + # spice-qemu-char.c spice_vmc_write(ssize_t out, int len) "spice wrottn %zd of requested %d" spice_vmc_read(int bytes, int len) "spice read %d of requested %d" -- 2.5.5