From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alx4C-0005BR-Pa for qemu-devel@nongnu.org; Fri, 01 Apr 2016 07:16:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alx4B-0001jm-Uz for qemu-devel@nongnu.org; Fri, 01 Apr 2016 07:16:40 -0400 Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:36246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alx4B-0001ji-Qo for qemu-devel@nongnu.org; Fri, 01 Apr 2016 07:16:39 -0400 Received: by mail-qg0-x231.google.com with SMTP id w104so87977535qge.3 for ; Fri, 01 Apr 2016 04:16:39 -0700 (PDT) Sender: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= From: marcandre.lureau@redhat.com Date: Fri, 1 Apr 2016 13:16:13 +0200 Message-Id: <1459509388-6185-4-git-send-email-marcandre.lureau@redhat.com> In-Reply-To: <1459509388-6185-1-git-send-email-marcandre.lureau@redhat.com> References: <1459509388-6185-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 03/18] char: use a trace for when the char is waiting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Yuanhan Liu , "Michael S. Tsirkin" , Ilya Maximets , jonshin@cisco.com, Tetsuya Mukawa , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= From: Marc-André Lureau Similarly to the reconnect error, this is an information message rather than an error. Use a trace event instead. Signed-off-by: Marc-André Lureau --- qemu-char.c | 3 +-- trace-events | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index a944ee0..8702931 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -4434,8 +4434,7 @@ static CharDriverState *qmp_chardev_open_socket(const char *id, } s->listen_ioc = sioc; if (is_waitconnect) { - fprintf(stderr, "QEMU waiting for connection on: %s\n", - chr->filename); + trace_char_socket_waiting(chr->filename); tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr); } qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), false, NULL); diff --git a/trace-events b/trace-events index 19e0a05..e59c0f5 100644 --- a/trace-events +++ b/trace-events @@ -691,6 +691,7 @@ leon3_reset_irq(int intno) "Reset CPU IRQ %d" # qemu-char.c char_socket_reconnect_error(const char *label, const char *err) "Unable to connect character device %s: %s" +char_socket_waiting(const char *filename) "QEMU waiting for connection on: %s" # spice-qemu-char.c spice_vmc_write(ssize_t out, int len) "spice wrottn %zd of requested %d" -- 2.5.5